Notice: Update dismiss button to match other Gutenberg UI#16926
Merged
Conversation
This matches our other close buttons throughout the interface.
karmatosed
approved these changes
Aug 7, 2019
karmatosed
left a comment
Member
There was a problem hiding this comment.
Approving design as this is a great unifying PR. Thanks for catching this.
Member
|
I'm seeing some js unit test error after this. Looks like you forgot to update a snapshot? |
Member
This PR was merged while there were failing tests. :/ |
ellatrix
added a commit
that referenced
this pull request
Aug 7, 2019
jorgefilipecosta
pushed a commit
that referenced
this pull request
Aug 7, 2019
Member
|
Thank you for fixing this problem @ellatrix. During the code review, we had another problem making CI tests fail and I did not notice the snapshot, I'm sorry for the potential troubles caused. |
Contributor
|
Thanks for taking care of this Kjell. 🎉 |
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Update hover/active/focus color to dark gray. * Update close button color to be darker. This matches our other close buttons throughout the interface. * Use no-alt instead of no dashicon.
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Update hover/active/focus color to dark gray. * Update close button color to be darker. This matches our other close buttons throughout the interface. * Use no-alt instead of no dashicon.
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the dismiss button in the Notice component is a little non-standard:
nodashicon, instead ofno-alt(which is used in our modal and sidebar panel close buttons)$dark-gray-300by default (instead of the usual$dark-gray-500), and is red on hover, regardless of the type of notification.This PR updates those to be more consistent.
Screenshots
Before:
Notice dismiss icon alongside the panel close icon:

Hovers:

After:
Notice dismiss icon alongside the panel close icon:

Hovers:

Testing
Pasting this into your console should produce all 4 standard dismissible notices.