Skip to content

Add new block indicator should show in place of empty block instead of below it#16272

Merged
marecar3 merged 2 commits intomasterfrom
rnmobile/1165_Add-new-block-indicator-should-show-in-place-of-empty-block-instead-of-below-it
Jun 25, 2019
Merged

Add new block indicator should show in place of empty block instead of below it#16272
marecar3 merged 2 commits intomasterfrom
rnmobile/1165_Add-new-block-indicator-should-show-in-place-of-empty-block-instead-of-below-it

Conversation

@marecar3
Copy link
Copy Markdown
Contributor

Fixes : wordpress-mobile/gutenberg-mobile#1165

To test:

  1. Open new Post
  2. Open block inserter

Result: Add Block Here should show above block

  1. Put some words into Block
  2. Open block inserter

Result: Add Block Here should show below block

ezgif com-video-to-gif (4)

@marecar3 marecar3 requested review from Tug and etoledom June 25, 2019 00:44

return (
<ReadableContentView>
<ReadableContentView reversed={ shouldReverseContent }>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clean solution, I like it 👍

Copy link
Copy Markdown
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@marecar3 marecar3 merged commit 56de120 into master Jun 25, 2019
@marecar3 marecar3 deleted the rnmobile/1165_Add-new-block-indicator-should-show-in-place-of-empty-block-instead-of-below-it branch June 25, 2019 15:56
@youknowriad youknowriad added this to the Gutenberg 6.1 milestone Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Empty blocks] "Add new block" indicator should show in place of empty block instead of below it

3 participants