Skip to content

[Mobile]: Fix broken imports on native rich-text.#14948

Merged
etoledom merged 2 commits intomasterfrom
rnmobile/fix-broken-imports-on-native-rich-text
Apr 12, 2019
Merged

[Mobile]: Fix broken imports on native rich-text.#14948
etoledom merged 2 commits intomasterfrom
rnmobile/fix-broken-imports-on-native-rich-text

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Apr 12, 2019 •
edited
Loading

This is a small PR to fix broken imports due to the addition of __unstable prefix.

To test:

  • Check out the related gutenberg-mobile PR.
  • Check that lists doesn't crash when adding a new list item (pressing Enter).

@etoledom etoledom requested a review from hypest April 12, 2019 13:19
@etoledom etoledom self-assigned this Apr 12, 2019
@etoledom etoledom added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Apr 12, 2019
@etoledom etoledom mentioned this pull request Apr 12, 2019
Closed
hypest referenced this pull request Apr 12, 2019
@ellatrix
RichText & Docs: remove or rename undocumented functions and constants (
e6e5d85 
#14239)

* RichText & Docs: remove or rename undocumented functions and constants

* Fix import after renaming
@hypest
Copy link
Copy Markdown
Contributor

hypest commented Apr 12, 2019

👋 @etoledom , I think insertLineBreak have been removed (replaced by plain use of insert). Can you check and remove it from mobile too?

@etoledom etoledom marked this pull request as ready for review April 12, 2019 15:03
@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented Apr 12, 2019

@hypest - Updated insertLineBreak() with insert().

I tested it by removing the split prop from the Heading block and having a multiline heading block.

Also works pressing shift in the simulator (with the computer's keyboard) and having multiline paragraph block.

hypest
hypest approved these changes Apr 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@etoledom etoledom merged commit 71a8c65 into master Apr 12, 2019
@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented Apr 12, 2019

Thank you!

@etoledom etoledom deleted the rnmobile/fix-broken-imports-on-native-rich-text branch April 12, 2019 15:31
@hypest
Copy link
Copy Markdown
Contributor

hypest commented Apr 13, 2019

Headsup. Found this after we merged this PR: There is another breakage. Line e6e5d85#diff-046b96483a89756efe39ddabba55d748R11 breaks the list type switching on native mobile. cc @ellatrix

mchowning pushed a commit to mchowning/gutenberg that referenced this pull request Apr 15, 2019
@etoledom @mchowning
[Mobile]: Fix broken imports on native rich-text. (WordPress#14948)
f77ba1d 
* Fix broken imports on native rich-text.

* RichText: Replace insertLineBreak() with insert();
@youknowriad youknowriad added this to the 5.5 (Gutenberg) milestone Apr 15, 2019
@ellatrix
Copy link
Copy Markdown
Member

ellatrix commented Apr 19, 2019

@hypest has everything been fixed now? Thanks!

@hypest
Copy link
Copy Markdown
Contributor

hypest commented Apr 19, 2019

All good by now Ella, thanks! For reference: #15010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hypest hypest hypest approved these changes

Assignees

@etoledom etoledom

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Milestone

5.5 (Gutenberg)

Development

Successfully merging this pull request may close these issues.

4 participants

@etoledom @hypest @ellatrix @youknowriad