Testing: Remove custom ESLint rules for import paths#13937
Merged
Conversation
5 tasks
gziolo
approved these changes
Feb 19, 2019
Member
gziolo
left a comment
There was a problem hiding this comment.
Yes, it makes a lot of sense now given that you would have to use very weird syntax like:
`import Button from '../../../components/src/button'
We still use it for mocks in tests though... However, it's an exception which was meant to be temporary 😅
Anyway, I think that we can remove those ESLint rules.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously: #3531, #3533
This pull request seeks to remove custom ESLint rules which were implemented at a time where the package pattern was first being introduced. Previously, attempting to
import from 'element'instead of from'@wordpress/element'would work, but bloat bundle sizes in the process. These days, however, the former import statement simply does not work (a build error will occur).By removing these custom ESLint rules, we avoid one additional step required when adding new packages. Notably, these rules don't encompass all current packages anyways.
Testing instructions:
Verify that changing any import to remove
@wordpress/prefix does not build.