Merged
Conversation
Aurorum
suggested changes
Feb 2, 2019
Contributor
Aurorum
left a comment
There was a problem hiding this comment.
I don't think this wording is ideal.
| { cannotEmbed && | ||
| <p className="components-placeholder__error"> | ||
| { __( 'Sorry, we could not embed that content.' ) }<br /> | ||
| { __( 'Sorry, this content could not be embed.' ) }<br /> |
Contributor
There was a problem hiding this comment.
I don't really think this makes sense as is. It makes me think twice, personally I'd prefer the use of the word "embedded" for consistency with the other message and because it's more frequently used.
Suggested change
| { __( 'Sorry, this content could not be embed.' ) }<br /> | |
| { __( 'Sorry, this content could not be embedded.' ) }<br /> |
Contributor
Author
There was a problem hiding this comment.
I've updated. Thanks for show me this mistake. I'm not native/fluent english speaker >.<
Contributor
There was a problem hiding this comment.
No worries, thanks for updating! :)
It looks great to me now.
gziolo
approved these changes
Feb 4, 2019
Member
gziolo
left a comment
There was a problem hiding this comment.
Thanks for fixing this issue 👍
daniloercoli
added a commit
that referenced
this pull request
Feb 5, 2019
…rnmobile/372-use-RichText-on-Title-block * 'master' of https://github.com/WordPress/gutenberg: (22 commits) Make the modal title styling consistent (#13669) Disable navigation block for text mode. (#12185) Fix: Linting problem in modal example code (#13671) Add myself as a code owner to the annotations (#13672) Add more reviewers to CODEOWNERS.md file (#13667) Plugin: Remove jQuery heartbeat-to-hooks proxying (#13576) Workflow: Add repository CODEOWNERS file (#13604) Add a mobile minimum size for form fields (#13639) Update edit-save documentation (#13578) Alt image setting (#13631) Fix: Allow years lower than 1970 in DateTime component. (#13602) Using addQueryArgs to generate Manage All Reusable Blocks link (#13653) Bump plugin version to 5.0.0-rc.1 (#13652) Update lodash to 4.17.10 (#13651) Refreshed PR (#9469) Set default values of the width and height input fields according to the actual image dimensions (#7687) 12647 fix css color picker (#12747) Remove "we" from messages (#13644) Fix: Font size picker max width on mobile (#13264) Fix/issue 12501 menu item aria label ...
This was referenced Feb 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* remove "we" from embed preview error message * remove "we" from embed placeholder * Change from "embed" to "embedded".
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* remove "we" from embed preview error message * remove "we" from embed placeholder * Change from "embed" to "embedded".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've removed "we" from messages in embed preview and embed placeholder
closes: #13643
How has this been tested?
This has been tested with "npm test" and manually on Chrome and Firefox
Types of changes
Bug fix
Checklist: