Accessibility: Avoid Keyboard trap on the editor content#1359
Merged
youknowriad merged 1 commit intomasterfrom Jun 22, 2017
Merged
Accessibility: Avoid Keyboard trap on the editor content#1359youknowriad merged 1 commit intomasterfrom
youknowriad merged 1 commit intomasterfrom
Conversation
Contributor
|
Quickly tested on Mac Chrome, Firefox, Safari: the keyboard trap is fixed, testing in the new, empty, post seems I end up with two empty blocks, is this expected?
|
afercia
reviewed
Jun 22, 2017
Contributor
afercia
left a comment
There was a problem hiding this comment.
The keyboard trap is fixed, one question: see comment
Contributor
Author
|
@afercia This is not two empty blocks. This is an empty block and a placeholder that eventually will be transformed into a block if we hit enter or click. This is expected. |
afercia
approved these changes
Jun 22, 2017
youknowriad
pushed a commit
that referenced
this pull request
Jan 17, 2020
Merge master (v1.12.0) back to develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1357
When the placeholder receives the focus, it is transformed into a text block and creating a new placeholder right after creating a tab trap.
The fix here keeps the behaviour of transforming to text block on focus only if the post content is empty. If the post content is not empty, you'll need to click "Enter" or mouse click to trigger the transformation.