i18n: Use placeholder for minimum WordPress version notice#13487
Merged
i18n: Use placeholder for minimum WordPress version notice#13487
Conversation
swissspidy
reviewed
Jan 24, 2019
Co-Authored-By: aduth <andrew@andrewduthie.com>
swissspidy
approved these changes
Jan 24, 2019
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* i18n: Use placeholder for minimum WordPress version notice * Collapse echo sprintf to printf Co-Authored-By: aduth <andrew@andrewduthie.com>
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* i18n: Use placeholder for minimum WordPress version notice * Collapse echo sprintf to printf Co-Authored-By: aduth <andrew@andrewduthie.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #13370 (comment)
This pull request seeks to update the string used in the minimum required version notice to use placeholders. This is done to avoid the string changing for translators between revisions to the minimum required version.
Testing instructions:
Downgrade to an earlier version of WordPress while Gutenberg is active, and verify there are no regressions in the display of the version notice when Gutenberg self-deactivates.