Change the inserter search result message from assertive to polite#13388
Merged
Change the inserter search result message from assertive to polite#13388
Conversation
f5e8b07 to
fa62d12
Compare
Contributor
Author
|
Rebased to incorporate the changes from #13395 and pass the tests. |
jorgefilipecosta
approved these changes
Jan 25, 2019
Member
jorgefilipecosta
left a comment
There was a problem hiding this comment.
I'm not sure of the reason why a message using 'assertive' option disappears faster, but I followed the test steps, and I verified that before the message disappeared almost immediately on voice over without being totally spoken and now the message is completely spoken.
Contributor
Author
|
Thanks @jorgefilipecosta. To clarify: it's the assertive message "61 results found" that was interrupting the screen reader while it was reading the search field label, so "Search for a block" wasn't announced. With this change, the search field label is read out first, followed by the number of results. |
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to improve screen readers behavior when using the Inserter. For more details please refer to the related issue #13387.
Please first test on current master:
Switch to this branch
Fixes #13387