Skip to content

Add onCaretVerticalPositionChange event#13323

Merged
pinarol merged 1 commit intomasterfrom
rnmobile/add-caret-vertical-position-change
Jan 17, 2019
Merged

Add onCaretVerticalPositionChange event#13323
pinarol merged 1 commit intomasterfrom
rnmobile/add-caret-vertical-position-change

Conversation

@pinarol
Copy link
Copy Markdown
Contributor

@pinarol pinarol commented Jan 15, 2019

Description

This PR adds onCaretVerticalPositionChange event to fix wordpress-mobile/gutenberg-mobile#464

How has this been tested?

Tested with steps on gutenberg-mobile PR

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pinarol pinarol merged commit df2fad3 into master Jan 17, 2019
@pinarol pinarol deleted the rnmobile/add-caret-vertical-position-change branch January 17, 2019 17:33
@gziolo gziolo added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) and removed [Status] In Progress Tracking issues with work in progress labels Jan 22, 2019
@gziolo gziolo added this to the 4.9 (Gutenberg) milestone Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS - There is no autoscroll to follow the cursor when the content goes behind the toolbar

3 participants