Components: Handle multiple Slots by same name#12882
Merged
Conversation
6294dda to
bdba6b8
Compare
johngodley
approved these changes
Jan 21, 2019
Contributor
johngodley
left a comment
There was a problem hiding this comment.
I've been unable to reproduce the original problem on master. I guess something changed that's affected the order in which block duplication happens, and the slot's aren't used in the same way.
If I try code from before this PR then the problem is reproducible, and this PR does fix it. I've tried to test other instances of Slot/Fill, and haven't seen any side-effects so far.
Regardless of whether the block duplication shortcut causes a problem in master I think the fix is still important. Nice 👍
bdba6b8 to
7079dd0
Compare
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12355
Alternative to: #12580
This pull request seeks to resolve an issue where multiple Slot instances using the same name can conflict:
bubblesVirtuallyistrue, since it usescreatePortalto render to a single nodeTesting instructions:
Repeat Steps to Reproduce from #12355, verifying that no duplicate toolbar is shown.
Verify there are no regressions in the behavior of Slot / Fill, both for
bubblesVirtuallytrue(e.g.Popovers) andfalse(e.g.BlockToolbars).Ensure unit tests pass: