Use sentence case in toolbar tooltips#12239
Merged
gziolo merged 1 commit intoWordPress:masterfrom Jan 25, 2019
Merged
Conversation
Member
|
Thanks for opening a follow-up PR. This fix looks okey but I will leave it to others to decide what is the best way to move forward. |
|
Yes, I would change these to sentence case. |
gziolo
approved these changes
Jan 25, 2019
Member
gziolo
left a comment
There was a problem hiding this comment.
Thanks for making it consistent. Nice work 👍
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #11708 with @gziolo, this PR changes instances where Title Case is used in toolbar tooltips to use Sentence case.
I've tested all blocks, and found that Title Case is used only in one more instance: for List View/Grid View in Latest Posts block.
This seems inconsistent with other blocks, should this be converted to styles, should we change strings to Convert to list view/Convert to grid view, or should we just change case?