Skip to content

NUX package: fix incorrect named deprecated import#11283

Merged
gziolo merged 1 commit intomasterfrom
fix/nux-package-deprecated-import
Oct 31, 2018
Merged

NUX package: fix incorrect named deprecated import#11283
gziolo merged 1 commit intomasterfrom
fix/nux-package-deprecated-import

Conversation

@vindl
Copy link
Copy Markdown
Member

@vindl vindl commented Oct 31, 2018

Description

DotTip component was attempting to import a named export of deprecated which
is not provided by @wordpress/deprecated package. This switches it to use the
default export instead.

Fixes #11282

See deprecated docs for correct usage: https://github.com/WordPress/gutenberg/tree/master/packages/deprecated#usage

How has this been tested?

  • Editor smoke test.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

DotTip component was attempting to import a named export of deprecated which
is not provided by @wordpress/deprecated package. This switches it to use the
deafult export instead.
@vindl vindl added [Type] Bug An existing feature does not function as intended [Package] NUX labels Oct 31, 2018
@vindl vindl self-assigned this Oct 31, 2018
@vindl vindl requested review from gziolo and youknowriad October 31, 2018 06:23
@vindl
Copy link
Copy Markdown
Member Author

vindl commented Oct 31, 2018

/cc @ramonjd

@vindl vindl added this to the 4.2 milestone Oct 31, 2018
Copy link
Copy Markdown
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Introduced here: 5aa410c

Copy link
Copy Markdown
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@gziolo gziolo merged commit 55d5aac into master Oct 31, 2018
@gziolo gziolo deleted the fix/nux-package-deprecated-import branch October 31, 2018 07:01
@gziolo gziolo modified the milestones: 4.2, 4.3 Oct 31, 2018
daniloercoli added a commit that referenced this pull request Oct 31, 2018
…rnmobile/port-quote-block-step-1

* 'master' of https://github.com/WordPress/gutenberg: (21 commits)
  Fix property path on get() call (#10962)
  Fixed typos on block api documentation (#11298)
  Export `switchToBlockType` to be used mobile side when merging two blocks. (#11294)
  RichText: Remove unused `ref` assignment to RichText (#11222)
  Remove findDOMNode from Tooltip component (#11169)
  Components: Remove redundant onClickOutside handler from Dropdown (#11253)
  added myself to the contributors list (#11260)
  Add complete post type labels for Resuable Blocks (#11278)
  Increase specificity for active radio/checkbox input styling (#11290)
  Fixed "artifact" misspelling in docs. (#11291)
  Nux package: fix incorrect named deprecated import (#11283)
  Rename parentClientId to rootClientId for consistency (#11274)
  chore(release): update changelog files
  chore(release): publish
  Update plugin version to 4.2.0. (#11258)
  Data: Use turbo-combine-reducers in place of Redux (#11255)
  Revert using Icon in IconButton to avoid regression in plugin icons (pinned icons) (#11256)
  Block List: Use default Inserter for sibling insertion (#11018)
  Editor: Optimize Inserter props generation and reconciliation (#11243)
  RichText: fix format placeholder (#11102)
  ...

# Conflicts:
#	packages/block-library/src/quote/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NUX package: trying to import non-existent deprecated named export

3 participants