Improve the style variation control aria-label#11045
Merged
Conversation
Member
|
If it's that essential we should probably only use the actual label of the style for aria-label without any suffix. |
Contributor
Author
|
@ocean90 thanks, makes sense. The panel title "Block Styles" will be always announced so repeating "style" is a bit pointless. |
ocean90
approved these changes
Oct 25, 2018
antpb
pushed a commit
to antpb/gutenberg
that referenced
this pull request
Oct 26, 2018
* Improve the style variation control aria-label. * Further simplify the aria-label to just use the style label or name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11044.
The accessible name of an UI control should match (or at least start with) the visible label. For more details please refer to the related issue #11044.
aria-labelfromApply style variation "%s"to%s styleFrom a l10n perspective, the variable at the beginning may not be ideal but it's essential for a11y reasons. I also wonder if we should add some info in the translators comment to inform translators to not move the variable and keep it at the beginning. /Cc @SergeyBiryukov @ocean90