Conversation
It overrides the default so the bold doesn’t appear
antpb
pushed a commit
to antpb/gutenberg
that referenced
this pull request
Oct 26, 2018
It overrides the default so the bold doesn’t appear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bold style on a cover image has no effect on the preview. Here the first word is made bold and has the same weight (300) as the second word:
The reason for this is that the cover block overrides the standard
strongweight and specifically sets it to 300. There may have been a reason for this in the past but it's one of the few places in Gutenberg wherestrongis changed, and removing it fixes the problem. As the CSS is only scoped to the cover block within the rich text editor I don't think it will affect anything else.Fixes #8202
How has this been tested?
Types of changes
Removes CSS override for
.wp-block-cover .editor-rich-text strongChecklist: