Conversation
This is an alternative to #10938 which for whatever reason I can't rebase. The purpose is the same: This PR fixes an icon size regression that was introduced in #9828. Basically SVG icons are _between 20 and 24px_. If an SVG has an explicit width, it uses that width, within the boundaries of those extremes. But unfortunately it also means if the SVG _doesn't_ have an explicit width or height, it collapses to the min-width and min-height. This PR updates documentation, and adds explicit dimensions for all block icons used. Before:  After: 
jasmussen
commented
Oct 24, 2018
|
|
||
| return icon(); | ||
| } else if ( icon && icon.type === 'svg' ) { | ||
| } else if ( isSVGIcon( icon ) ) { |
Contributor
Author
There was a problem hiding this comment.
I wanted to write this way simpler, like this:
} else if ( icon && icon.type === 'svg' || icon && icon.type.name === 'SVG' ) {
const appliedProps = {
...icon.props,
width: icon.props.width || 24,
height: icon.props.height || 24,
};
return <SVG { ...appliedProps } />;
}
But for whatever reason, this did not pass linting tests. I'm not sure why, as this implementation seems far more complex.
gziolo
reviewed
Oct 24, 2018
| function isSVGIcon( icon ) { | ||
| if ( icon && icon.type === 'svg' ) { | ||
| return true; | ||
| } else if ( icon && icon.type.name === 'SVG' ) { |
Member
There was a problem hiding this comment.
You can check also refactor it as:
return icon && ( icon.type === 'svg' || icon.type === SVG );
Contributor
Author
There was a problem hiding this comment.
You mean
return icon && ( icon.type === 'svg' || icon.type.name === SVG );
right?
If so, YAY, that's what I wanted! Thank you. Will update.
Member
There was a problem hiding this comment.
Nope, my code is correct. .name is less reliable.
Contributor
Author
There was a problem hiding this comment.
Oh really, will that work? Let me give it a shot! Thanks again.
Member
There was a problem hiding this comment.
it's the same thing as with <svg - type is the name of the component that was used to create an actual element - in first case it's svg (string for html tag has special handling), in the second it's the SVG component.
Contributor
Author
There was a problem hiding this comment.
Okay, pushed 1f4a19b — is that kosher? I don't like creating an entirely new function if we don't have to.
Contributor
|
🚢 |
antpb
pushed a commit
to antpb/gutenberg
that referenced
this pull request
Oct 26, 2018
* Fix icon size regression. This is an alternative to WordPress#10938 which for whatever reason I can't rebase. The purpose is the same: This PR fixes an icon size regression that was introduced in WordPress#9828. Basically SVG icons are _between 20 and 24px_. If an SVG has an explicit width, it uses that width, within the boundaries of those extremes. But unfortunately it also means if the SVG _doesn't_ have an explicit width or height, it collapses to the min-width and min-height. This PR updates documentation, and adds explicit dimensions for all block icons used. Before:  After:  * Pretty up the code a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #10938 which for whatever reason I can't rebase. The purpose is the same:
This PR fixes an icon size regression that was introduced in #9828. Basically SVG icons are between 20 and 24px.
If an SVG has an explicit width, it uses that width, within the boundaries of those extremes. But unfortunately it also means if the SVG doesn't have an explicit width or height, it collapses to the min-width and min-height.
This PR updates documentation, and adds explicit dimensions for all block icons used.
Before:
After: