Skip to content

Fix changelog issue.#10953

Merged
jasmussen merged 3 commits intomasterfrom
fix/changelog-issue
Oct 23, 2018
Merged

Fix changelog issue.#10953
jasmussen merged 3 commits intomasterfrom
fix/changelog-issue

Conversation

@jasmussen
Copy link
Copy Markdown
Contributor

This PR fixes a typo in a previous changelog change, which happened because the 5.0.1 version was already published. This bumps it to 5.0.2.

Let me know if this looks good.

This PR fixes a typo in a previous changelog change, which happened because the 5.0.1 version was already published. This bumps it to 5.0.2.
@jasmussen jasmussen added the [Type] Bug An existing feature does not function as intended label Oct 23, 2018
@jasmussen jasmussen self-assigned this Oct 23, 2018
@@ -1,4 +1,4 @@
## 5.0.1 (2018-10-22)
## 5.0.2 (2018-10-22)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing the existing entry you have add yours as unreleased like this:

## 5.0.2 (unreleased)

### Polish
- Add animated logo to preview interstitial screen.

## 5.0.1 (2018-10-22)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this? e92caad

Thanks for the patience. I've only ever published one project to NPM and it was a while ago. I'll get this.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasmussen No worries. 🙂Now you only have to readd the ## 5.0.1 (2018-10-22) line and then it's good to go.

@swissspidy
Copy link
Copy Markdown
Member

Was there no changelog for 5.0.1? Now with this PR it goes straight from 5.0.0 to 5.0.2 in the changelog.

@jasmussen
Copy link
Copy Markdown
Contributor Author

It doesn't seem like a changelog item was added for 5.0.1, I'm not really sure where the process broke down as I'm still new to this.

@jasmussen
Copy link
Copy Markdown
Contributor Author

jasmussen commented Oct 23, 2018

Pushed a change. Okay to go now? Thanks again for the patience.

@ocean90
Copy link
Copy Markdown
Member

ocean90 commented Oct 23, 2018

Thanks @jasmussen!

@jasmussen jasmussen merged commit a563dc7 into master Oct 23, 2018
@jasmussen jasmussen deleted the fix/changelog-issue branch October 23, 2018 15:24
@jasmussen jasmussen added this to the 4.2 milestone Oct 23, 2018
antpb pushed a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018
* Fix changelog issue.

This PR fixes a typo in a previous changelog change, which happened because the 5.0.1 version was already published. This bumps it to 5.0.2.

* Address feedback.

* Address feedback?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants