File Block: Set the download attribute as empty#10948
Merged
Merged
Conversation
4 tasks
tofumatt
approved these changes
Oct 23, 2018
tofumatt
left a comment
Member
There was a problem hiding this comment.
A test here would be appreciated, but looks good to me.
Member
|
(Oh, never mind: you'll need to fix your snapshot test though; that test failure is legitimate.) |
9f044df to
47d6bde
Compare
Member
|
This isn't going to work, KSES expects a valueless attribute to not have a value at all, not to have an empty value. (eg, |
4 tasks
Contributor
Author
|
@pento I'm not familiar with the serialization process of a block, but here for some reasons EDIT: scratch everything, this is why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces #10693
Set the File Block's "Download" button's
downloadattribute as empty.The addition of the
downloadattribute foratags to thewp_kseswhitelist has been recently blocked (cc @pento):Note
The attribute has been set as empty string (
download="") instead of valueless (downloadordownload={ true }) because in the latter case it was always stripped away at the first block update, breaking it altogether.How has this been tested?
Manually on a local environment, checking for regressions.
Checklist: