UI Prototype: Try the dockerized controls prototype#108
Merged
youknowriad merged 2 commits intomasterfrom Feb 21, 2017
Merged
Conversation
Contributor
|
Woot, I love it! You work so fast. In this block interface, the onselect formatting controls should be visible as soon as you click the block, no reason to hide them anymore. I made this animatic to illustrate how it could look:
There are some design tweaks I'd like to make but don't let those hold you back, I can polish in a separate PR. |
Contributor
Author
Hey! this made the code simpler 👍
Glad you like it :) and the fact that it's a prototype helps working faster. |
Contributor
|
Love it! 👍 |
jasmussen
approved these changes
Feb 21, 2017
nylen
pushed a commit
that referenced
this pull request
Mar 16, 2017
hypest
pushed a commit
that referenced
this pull request
Nov 2, 2018
…ling Inserter - fix focus handling, awesomely spotted by @hypest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I'm trying the dockerized controls approach to match the last mockups