Speak: Add/complete audible feedback for link editing#10795
Merged
Conversation
94f692a to
2a9fb0c
Compare
Member
|
No tests? :( |
Member
|
My bad 😓, I've filed: #11006 and assigned it to me! |
antpb
pushed a commit
to antpb/gutenberg
that referenced
this pull request
Oct 26, 2018
* Speak ‘link removed’ when a link is removed * Speak ‘link edited’ when a link is edited
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When users complete an action adding, editing or removing a link announce those action completions to assistive screen readers.
Fixes #1867
How has this been tested?
Adding and removing links in chrome with mac voice over enabled - the actions were properly announced.
Types of changes
Checklist: