Replace gutenberg in classNames with block-editor#10783
Merged
youknowriad merged 1 commit intomasterfrom Oct 19, 2018
Merged
Conversation
df24788 to
28d13a8
Compare
gziolo
reviewed
Oct 19, 2018
| * The main entry point for the Gutenberg editor. Renders the editor on the | ||
| * wp-admin page for the plugin. | ||
| * | ||
| * The gutenberg and gutenberg__editor classNames are left for backward compatibility. |
Member
There was a problem hiding this comment.
Do we really need it? It's going to be moved to WordPress core as far as I understand?
Member
There was a problem hiding this comment.
Yah, all of this is going to be committed to Core.
pento
approved these changes
Oct 19, 2018
Member
pento
left a comment
There was a problem hiding this comment.
I'm not too fussed whether the plugin keeps the old class names for a little bit, the main thing is that all the CSS is changed, so I can drop them from core. 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #10777
Testing instructions