Skip to content

UI Prototype: Add indication that there are more blocks available#107

Merged
youknowriad merged 1 commit intomasterfrom
add/scroll-indication
Feb 21, 2017
Merged

UI Prototype: Add indication that there are more blocks available#107
youknowriad merged 1 commit intomasterfrom
add/scroll-indication

Conversation

@youknowriad
Copy link
Copy Markdown
Contributor

closes #98

In this small PR, I'm adding a box-shadow when the block menu is scrollable indicating that there are more blocks. The shadow is dropped when we hit the bottom.

@youknowriad youknowriad added [Type] Enhancement A suggestion for improvement. UI Prototype labels Feb 21, 2017
@youknowriad youknowriad self-assigned this Feb 21, 2017
@jasmussen
Copy link
Copy Markdown
Contributor

Love it. Ship it!

@youknowriad youknowriad merged commit 8606884 into master Feb 21, 2017
@youknowriad youknowriad deleted the add/scroll-indication branch February 21, 2017 10:21
@aduth
Copy link
Copy Markdown
Member

aduth commented Feb 21, 2017

Do you think the gradient should disappear/reappear immediately or with a transition effect?

@jasmussen
Copy link
Copy Markdown
Contributor

Do you think the gradient should disappear/reappear immediately or with a transition effect?

It'd be nice if it "lifted off the page" as it became necessary, absolutely!

But for the UI prototype, this is definitely good for now. Also on the to-do list is revisiting the inserter entirely — the UI prototype has already shown it to have a couple of weaknesses in its feel. See also: #34.

hypest added a commit that referenced this pull request Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add indication there are more blocks

3 participants