[ReactNative] Refactor block splitting code on paragraph and heading blocks#10690
Merged
diegoreymendez merged 1 commit intomasterfrom Oct 18, 2018
Merged
Conversation
… and Heading blocks for mobile, tryin gto stay closer to the web version.
diegoreymendez
approved these changes
Oct 18, 2018
Contributor
diegoreymendez
left a comment
There was a problem hiding this comment.
I configured my local environment to test this in Android too, and there truly isn't much to test... but at least I was able to check that it's not crashing.
antpb
pushed a commit
to antpb/gutenberg
that referenced
this pull request
Oct 26, 2018
… and Heading blocks for mobile, tryin gto stay closer to the web version. (WordPress#10690)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I started the refactor of the code that handles block splitting (for Paragraph and Heading blocks) on Enter.KEY and tried to stay closer to the web implementation.
@diegoreymendez this is just a working in progress, but worth to get this merged since it will probably affect the Native wrapper around Aztec. See the hack here.
Internally there is a conversion from HTML to RichText format, and the position of the cursor obviously doesn't match. Consequence of this, the code that actually does the split uses a wrong index and split at "arbitrary" position.
Maybe just returning the "geographical" position of the cursor in Aztec will fix this issue. We need to investiga that better, so having this merged will help.