Merged
Conversation
Member
jorgefilipecosta
left a comment
There was a problem hiding this comment.
While I totally agree that for empty strings ('') we should return 0, I'm not sure if we should return 0 if the text is null or undefined. Maybe we can stay on the safe side and just return 0 for empty strings keeping the undefined return for other "falsy" values.
Member
Author
|
@jorgefilipecosta |
jorgefilipecosta
approved these changes
Oct 25, 2018
Member
jorgefilipecosta
left a comment
There was a problem hiding this comment.
LGTM 👍 Thank you for iterating on this!
antpb
pushed a commit
to antpb/gutenberg
that referenced
this pull request
Oct 26, 2018
* Return 0 if text is empty * return 0 with empty stirng * return 0 for enpty string * small typo * Add message to changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wordcount should return 0 if text is empty.
Screenshots
before
after
