Testing: Add missing e2e tests for Plugins API#10513
Merged
Conversation
321f1f2 to
5bb3c86
Compare
jorgefilipecosta
approved these changes
Oct 24, 2018
Member
jorgefilipecosta
left a comment
There was a problem hiding this comment.
The new test cases look good to me 👍
5bb3c86 to
f2d5e89
Compare
antpb
pushed a commit
to antpb/gutenberg
that referenced
this pull request
Oct 26, 2018
* Testing: Add missing e2e tests for Plugins API * Make all plugin API e2e test independent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two basic tests for Publish Panel components integrated with Plugins API. I noticed that I added plugins before WordCamp Europe. Apparently, I forgot to add tests, this PR fixes it.
This PR also wraps JavaScript code of test plugins with IIFE (Immediately-invoked function expression) to avoid polluting global namespace.
How has this been tested?
npm run test-e2eplus the same check on Travis.Checklist: