Have Travis run mobile tests that use the parent code#10034
Merged
Conversation
Contributor
Author
…-use-the-parent-code
ellatrix
approved these changes
Sep 20, 2018
aduth
pushed a commit
that referenced
this pull request
Oct 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Until now, Travis was running the mobile tests but those were actually using the deeply nested Gutenberg filetree (a nested submodule inside the mobile submodule), resulting to false positive "green" runs.
This PR adds a flag to the mobile related Travis jobs to make them use the proper configuration where the mobile tests should assume to be running from inside the Gutenberg folder.
How has this been tested?
This is a Travis change and the testing is done by looking at the Travis run on this PR.
In particular, when looking at the 2 mobile job outputs, one can see this:
where the important bit is the
jest_gb.config.js. That's the Jest configuration that sets the Gutenberg package paths to point one directory up from the mobile submodule. That's what we need to have the mobile tests use the code/changes found in the parent folder.Types of changes
Adds a shell flag to the Travis configuration of the mobile jobs.
To test:
Open the Travis output https://travis-ci.org/WordPress/gutenberg/jobs/430595120#L5410 and notice the
jest_gb.config.jsbit.Checklist: