Skip to content

Collection snapshot#22

Merged
Taluu merged 6 commits intoWisembly:masterfrom
Taluu:collection-snapshot
Jul 19, 2014
Merged

Collection snapshot#22
Taluu merged 6 commits intoWisembly:masterfrom
Taluu:collection-snapshot

Conversation

@Taluu
Copy link
Contributor

@Taluu Taluu commented Jul 17, 2014

Should fix #19 and probably fit with #21. But it is not really recursive, as there's no guarantee that an array with numerical indexed elements are collections, and if they are, if they have the same type of primary key.

  • Add a ward against trying to normalize a data that is already a snapshot
  • CollectionSnapshot
  • Unit Tests
  • Use Symfony's PropertyAccess component
  • Allow to pass some options into the CollectionSnapshot (like a directive to tell the snapshot which sub-snapshot to use for each values of the collection)

@Taluu
Copy link
Contributor Author

Taluu commented Jul 19, 2014

Removed the recursive item from the todo list, as I don't see any easy way to handle this.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.81%) when pulling ea2952d on Taluu:collection-snapshot into 5b6994f on Wisembly:master.

Taluu added a commit that referenced this pull request Jul 19, 2014
@Taluu Taluu merged commit 05eb4dc into Wisembly:master Jul 19, 2014
@Taluu Taluu deleted the collection-snapshot branch July 19, 2014 18:59
This was referenced Jul 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants