Add support for Node.js v26 prebuilds and remove EOL builds#1468
Merged
Conversation
Contributor
Author
|
Node v26 tests are failing because of yargs/yargs#2509. Deja vu 😵💫. |
Contributor
Author
|
All good to go. Pinging @Prinzhorn. |
Contributor
|
Is there a reason to keep 20/23 in the engines list? |
Contributor
Author
|
I expected some people to be still using Node 20 on their stable applications, and given projects like node-nes, it was acceptable IMO. Mostly, the concern is that some CIs/builders consider the "unsupported engine" warning as an error, which would stop them from building the binaries themselves. I saw someone complaining about it. Technically, BS3 is still fully functional on these legacy engines, so we'll keep v20 for now. We just won't be building prebuilt binaries for them. I say let's keep them in supported engines till the next LTS. |
Prinzhorn
approved these changes
May 11, 2026
sweir1
added a commit
to sweir1/obsidian-brain
that referenced
this pull request
May 16, 2026
No code behavior changes. Polish release.
Docs
- docs/embeddings.md: "Auto-pull on first boot" admonition next to the
Ollama setup snippet, pointing at models.md BYOM section. Closes
the discoverability gap where users reading top-down didn't see the
v1.7.23 BYOM gate until hitting the actionable error.
Dependency bumps (5 devDeps)
- @types/node 25.6.2 → 25.8.0
- @vitest/coverage-v8 4.1.5 → 4.1.6
- fast-check 4.7.0 → 4.8.0
- tsx 4.21.0 → 4.22.0
- vitest 4.1.5 → 4.1.6
Held back: better-sqlite3 12.9.0 → 12.10.0
Changelog (WiseLibs/better-sqlite3#1468) says 12.10.0 removed Node.js
v20 prebuilt binaries. Our package.json says >=20.19.0, so taking
12.10.0 would force Node-20 users to compile from source. The
Node-minimum bump is queued for v1.8.0 alongside other potentially
breaking changes.
Verification
- 12/12 preflight green
- 1010 passed | 1 skipped (1011 total) — unchanged from v1.7.23
- tsc clean, smoke 18/18
- 0 npm audit vulnerabilities
sweir1
added a commit
to sweir1/obsidian-brain
that referenced
this pull request
May 16, 2026
No code behavior changes. Polish release.
Docs
- docs/embeddings.md: "Auto-pull on first boot" admonition next to the
Ollama setup snippet, pointing at models.md BYOM section. Closes
the discoverability gap where users reading top-down didn't see the
v1.7.23 BYOM gate until hitting the actionable error.
Dependency bumps (5 devDeps)
- @types/node 25.6.2 → 25.8.0
- @vitest/coverage-v8 4.1.5 → 4.1.6
- fast-check 4.7.0 → 4.8.0
- tsx 4.21.0 → 4.22.0
- vitest 4.1.5 → 4.1.6
Held back: better-sqlite3 12.9.0 → 12.10.0
Changelog (WiseLibs/better-sqlite3#1468) says 12.10.0 removed Node.js
v20 prebuilt binaries. Our package.json says >=20.19.0, so taking
12.10.0 would force Node-20 users to compile from source. The
Node-minimum bump is queued for v1.8.0 alongside other potentially
breaking changes.
Verification
- 12/12 preflight green
- 1010 passed | 1 skipped (1011 total) — unchanged from v1.7.23
- tsc clean, smoke 18/18
- 0 npm audit vulnerabilities
(cherry picked from commit 859a1e6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Node.js v26 and removed EOL versions 20 and 23.