Skip to content

Fix Node v25 test errors#1454

Merged
mceachen merged 2 commits intoWiseLibs:masterfrom
m4heshd:fix-node-25-test-errors
Mar 11, 2026
Merged

Fix Node v25 test errors#1454
mceachen merged 2 commits intoWiseLibs:masterfrom
m4heshd:fix-node-25-test-errors

Conversation

@m4heshd
Copy link
Copy Markdown
Contributor

@m4heshd m4heshd commented Mar 11, 2026

Testing against Node v25 is currently problematic due to nodejs/node#61971. This locks the test runtime version to the last known working version. This also disables fail-fast for tests.

@m4heshd m4heshd requested review from a team and JoshuaWise as code owners March 11, 2026 07:07
Copy link
Copy Markdown
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sleuthing that out!

@mceachen mceachen merged commit 128cdf4 into WiseLibs:master Mar 11, 2026
30 checks passed
@mceachen
Copy link
Copy Markdown
Member

Fixed? nodejs/node#61971 (comment)

mceachen added a commit that referenced this pull request Mar 11, 2026
@mceachen
Copy link
Copy Markdown
Member

Yup, the revert passed, @m4heshd can you check out #1455 please

mceachen added a commit that referenced this pull request Mar 11, 2026
* Revert "Fix Node v25 test errors (#1454)"

This reverts commit 128cdf4.

* ci: disable fail-fast in test job strategy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants