Skip to content

Add NodeJS v25 support#1412

Closed
daniel-hauser wants to merge 2 commits intoWiseLibs:masterfrom
daniel-hauser:feat/node-25
Closed

Add NodeJS v25 support#1412
daniel-hauser wants to merge 2 commits intoWiseLibs:masterfrom
daniel-hauser:feat/node-25

Conversation

@daniel-hauser
Copy link
Copy Markdown

@daniel-hauser daniel-hauser commented Oct 17, 2025

This pull request updates the Node.js version support for the project, adding compatibility for Node.js v25

  • Updated the NODE_BUILD_CMD in .github/workflows/build.yml to include Node.js v25, ensuring prebuilt binaries are generated for this version.
  • Added Node.js v25 to the test matrix in .github/workflows/build.yml so that CI tests run against this version.
  • Updated the engines.node field in package.json to include Node.js v25, formally declaring support for this version.
  • Changed the minimum required Node.js version in README.md from v14.21.1 to v20.0.0 to match the current support policy.

Fixes #1411

@daniel-hauser daniel-hauser requested review from a team and JoshuaWise as code owners October 17, 2025 20:45
LitoMore
LitoMore reviewed Oct 18, 2025
View reviewed changes
package.json
],
"engines": {
"node": "20.x || 22.x || 23.x || 24.x"
"node": "20.x || 22.x || 23.x || 24.x || 25.x"
Copy link
Copy Markdown

@LitoMore LitoMore Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just using >=20?

Copy link
Copy Markdown
Author

@daniel-hauser daniel-hauser Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explicitly added 25 to match it with the prebuild that is for a closed list of versions

Copy link
Copy Markdown
Member

@mceachen mceachen Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I’d be fine with either approach

@daniel-hauser daniel-hauser mentioned this pull request Oct 19, 2025
Closed
mceachen
mceachen previously approved these changes Oct 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@mceachen
Copy link
Copy Markdown
Member

mceachen commented Oct 19, 2025

Bummer, it seems like node 25 needs a newer compiler toolchain? https://github.com/WiseLibs/better-sqlite3/actions/runs/18604446742/job/53116228499?pr=1412 I suspect pulling in a new gcc will require a newer Ubuntu host image. Perhaps we only make the newer Ubuntu a requirement for node 25?

@daniel-hauser
Copy link
Copy Markdown
Author

daniel-hauser commented Oct 20, 2025 •
edited
Loading

Bummer, it seems like node 25 needs a newer compiler toolchain? https://github.com/WiseLibs/better-sqlite3/actions/runs/18604446742/job/53116228499?pr=1412 I suspect pulling in a new gcc will require a newer Ubuntu host image. Perhaps we only make the newer Ubuntu a requirement for node 25?

From what i read, gcc11 should work. Can you approve the workflow run so we can see if it works?

mceachen added a commit to mceachen/better-sqlite3 that referenced this pull request Nov 17, 2025
@mceachen
chore(build): add support for node 25 (see WiseLibs#1412)
808fa07
@mceachen mceachen mentioned this pull request Nov 17, 2025
Merged
JoshuaWise pushed a commit that referenced this pull request Nov 21, 2025
@mceachen
Add support for Node v25 and Electron 39+ prebuilds (#1422)
4df8c50 
* chore(build): Add support for Electron 39+ builds in CI workflow by running those prebuilds with bookworm (and keeping the older prebuilds on bullseye). Fixes #1421

* chore(build): add support for node 25 (see #1412)
@JoshuaWise
Copy link
Copy Markdown
Member

JoshuaWise commented Nov 21, 2025

Superseded by #1422

@JoshuaWise JoshuaWise closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaWise JoshuaWise Awaiting requested review from JoshuaWise JoshuaWise is a code owner

@mceachen mceachen Awaiting requested review from mceachen

1 more reviewer

@LitoMore LitoMore LitoMore left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

better-sqlite3 12.3.0 fails to build on Node.js latest (25)

4 participants

@daniel-hauser @mceachen @JoshuaWise @LitoMore