Merged
Conversation
… defaulting self.height to 600px from 500px.
…ly situation where there needs to be a lib directory in the root of the local deployment is when pyvis is generating the html for a notebook and the notebook is serving the contents locally. This was some legacy code that was not as thouroughly checked when the last deployment went live and because of how it was coded the lib directory would get overwritten only when there was already a lib directory present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issues brought up in #174
This was some legacy code in the directory that was handling some of the lib directory deployment, but due to an oversite it was missed what this code was doing due to the test environment either not having a lib folder to overwrite or being tested in the root of the pyvis application itself. As such this was not caught before it was updated.
This aims to fix the problem in a couple of ways: