Skip to content

Digital Credentials: IdentityCredentialProtocol was renamed DigitalCredentialPresentationProtocol#57027

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
marcoscaceres:eng/Digital-Credentials-IdentityCredentialProtocol-was-renamed-DigitalCredentialPresentationProtocol
Jan 23, 2026
Merged

Digital Credentials: IdentityCredentialProtocol was renamed DigitalCredentialPresentationProtocol#57027
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
marcoscaceres:eng/Digital-Credentials-IdentityCredentialProtocol-was-renamed-DigitalCredentialPresentationProtocol

Conversation

@marcoscaceres

@marcoscaceres marcoscaceres commented Jan 22, 2026 •
edited by webkit-early-warning-system
Loading

Copy link
Copy Markdown
Contributor

5435910

Digital Credentials: IdentityCredentialProtocol was renamed DigitalCredentialPresentationProtocol
rdar://168641111
https://bugs.webkit.org/show_bug.cgi?id=305989

Reviewed by Anne van Kesteren.

Renamed IdentityCredentialProtocol to DigitalCredentialPresentationProtocol.
Spec change:
w3c-fedid/digital-credentials#401

Relies on existing tests.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/identity/DigitalCredential.cpp:
(WebCore::DigitalCredential::create):
(WebCore::DigitalCredential::DigitalCredential):
(WebCore::convertProtocolString):
(WebCore::jsToCredentialRequest):
* Source/WebCore/Modules/identity/DigitalCredential.h:
* Source/WebCore/Modules/identity/DigitalCredential.idl:
* Source/WebCore/Modules/identity/DigitalCredentialPresentationProtocol.h: Renamed from Source/WebCore/Modules/identity/IdentityCredentialProtocol.h.
* Source/WebCore/Modules/identity/DigitalCredentialPresentationProtocol.idl: Renamed from Source/WebCore/Modules/identity/IdentityCredentialProtocol.idl.
* Source/WebCore/Modules/identity/DigitalCredentialsResponseData.h:
* Source/WebCore/Modules/identity/protocols/DigitalCredentialsProtocols.h:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/DigitalCredentials/WKDigitalCredentialsPicker.mm:
(-[WKRequestDataResult initWithRequestDataBytes:protocol:]):
(-[WKDigitalCredentialsPicker handlePresentmentCompletionWithResponse:error:]):

Canonical link: https://commits.webkit.org/306123@main

d03d5d6

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@marcoscaceres marcoscaceres self-assigned this Jan 22, 2026
@webkit-early-warning-system

webkit-early-warning-system commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on previous version of this PR (hash ab8e2f0)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@marcoscaceres marcoscaceres mentioned this pull request Jan 22, 2026
Merged
9 tasks
annevk
annevk approved these changes Jan 22, 2026
View reviewed changes

@annevk annevk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo bots.

@marcoscaceres marcoscaceres added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jan 22, 2026
@marcoscaceres marcoscaceres force-pushed the eng/Digital-Credentials-IdentityCredentialProtocol-was-renamed-DigitalCredentialPresentationProtocol branch from ab8e2f0 to d03d5d6 Compare January 23, 2026 01:50
@webkit-early-warning-system

webkit-early-warning-system commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on current version of this PR (hash d03d5d6)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ✅ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests ✅ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot

webkit-ews-buildbot commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

Failed wpe-wk2 checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #57027 from merge queue.

@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jan 23, 2026
@webkit-ews-buildbot

webkit-ews-buildbot commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

Safe-Merge-Queue: Build #81799.

@marcoscaceres marcoscaceres added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jan 23, 2026
@marcoscaceres
Digital Credentials: IdentityCredentialProtocol was renamed DigitalCr…
5435910 
…edentialPresentationProtocol

rdar://168641111
https://bugs.webkit.org/show_bug.cgi?id=305989

Reviewed by Anne van Kesteren.

Renamed IdentityCredentialProtocol to DigitalCredentialPresentationProtocol.
Spec change:
w3c-fedid/digital-credentials#401

Relies on existing tests.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Headers.cmake:
* Source/WebCore/Modules/identity/DigitalCredential.cpp:
(WebCore::DigitalCredential::create):
(WebCore::DigitalCredential::DigitalCredential):
(WebCore::convertProtocolString):
(WebCore::jsToCredentialRequest):
* Source/WebCore/Modules/identity/DigitalCredential.h:
* Source/WebCore/Modules/identity/DigitalCredential.idl:
* Source/WebCore/Modules/identity/DigitalCredentialPresentationProtocol.h: Renamed from Source/WebCore/Modules/identity/IdentityCredentialProtocol.h.
* Source/WebCore/Modules/identity/DigitalCredentialPresentationProtocol.idl: Renamed from Source/WebCore/Modules/identity/IdentityCredentialProtocol.idl.
* Source/WebCore/Modules/identity/DigitalCredentialsResponseData.h:
* Source/WebCore/Modules/identity/protocols/DigitalCredentialsProtocols.h:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/DigitalCredentials/WKDigitalCredentialsPicker.mm:
(-[WKRequestDataResult initWithRequestDataBytes:protocol:]):
(-[WKDigitalCredentialsPicker handlePresentmentCompletionWithResponse:error:]):

Canonical link: https://commits.webkit.org/306123@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Digital-Credentials-IdentityCredentialProtocol-was-renamed-DigitalCredentialPresentationProtocol branch from d03d5d6 to 5435910 Compare January 23, 2026 23:21
@webkit-commit-queue

webkit-commit-queue commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

Committed 306123@main (5435910): https://commits.webkit.org/306123@main

Reviewed commits have been landed. Closing PR #57027 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5435910 into WebKit:main Jan 23, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annevk annevk annevk approved these changes

Assignees

@marcoscaceres marcoscaceres

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marcoscaceres @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @annevk