Skip to content

[Temporal] Add toString, toJSON, and toLocaleString methods for PlainYearMonth #54717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Dec 3, 2025
Merged

[Temporal] Add toString, toJSON, and toLocaleString methods for PlainYearMonth #54717

webkit-commit-queue merged 1 commit into from
Dec 3, 2025

Conversation

@catamorphism
Copy link
Contributor

@catamorphism catamorphism commented Dec 2, 2025 •
edited by webkit-early-warning-system
Loading

bf9ae75

[Temporal] Add toString, toJSON, and toLocaleString methods for PlainYearMonth
https://bugs.webkit.org/show_bug.cgi?id=303413

Reviewed by Darin Adler.

Implement these methods.

Co-authored-by: Darin Adler <33187212+darinadler@users.noreply.github.com>

* JSTests/stress/temporal-plainyearmonth.js:
(shouldThrow):
* JSTests/test262/config.yaml:
* JSTests/test262/expectations.yaml:
* Source/JavaScriptCore/runtime/ISO8601.cpp:
(JSC::ISO8601::temporalYearMonthToString):
* Source/JavaScriptCore/runtime/ISO8601.h:
* Source/JavaScriptCore/runtime/TemporalPlainYearMonth.cpp:
(JSC::TemporalPlainYearMonth::toString const):
* Source/JavaScriptCore/runtime/TemporalPlainYearMonth.h:
* Source/JavaScriptCore/runtime/TemporalPlainYearMonthPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):

Canonical link: https://commits.webkit.org/303866@main

3fba7ca

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 api-mac-debug ⏳ 🛠 wpe-cairo
✅ 🛠 🧪 jsc   🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp   🧪 jsc-armv7-tests
  🛠 watch
✅ 🛠 watch-sim

@catamorphism catamorphism requested a review from a team as a code owner December 2, 2025 20:57
@catamorphism catamorphism self-assigned this Dec 2, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 2, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 4be93cf)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win
  🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt ⏳ 🧪 api-mac-debug ⏳ 🛠 wpe-cairo
  🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk1   🛠 gtk
✅ 🛠 🧪 jsc-arm64   🛠 vision   🧪 mac-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-AS-debug-wk2   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-wk2-stress   🛠 playstation
  🛠 tv   🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
  🛠 tv-sim ✅ 🛠 mac-safer-cpp ⏳ 🧪 jsc-armv7-tests
  🛠 watch
  🛠 watch-sim

@catamorphism catamorphism added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Dec 2, 2025
@catamorphism catamorphism force-pushed the plainmonthday-plainyearmonth-part-9 branch from 4be93cf to 0128c33 Compare December 2, 2025 20:59
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 2, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 0128c33)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ⏳ 🧪 api-mac-debug ⏳ 🛠 wpe-cairo
✅ 🛠 🧪 jsc   🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ❌ 🛠 vision ✅ 🧪 mac-wk2   🧪 gtk-wk2
  🛠 vision-sim ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress   🛠 playstation
❌ 🛠 tv ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
  🛠 tv-sim ✅ 🛠 mac-safer-cpp ⏳ 🧪 jsc-armv7-tests
  🛠 watch
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 2, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 2, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 428f09e)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios   🛠 mac ✅ 🛠 wpe   🛠 win
  🛠 ios-sim   🛠 mac-AS-debug ⏳ 🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 api-mac-debug ⏳ 🛠 wpe-cairo
  🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64   🛠 vision   🧪 mac-wk2 ⏳ 🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-AS-debug-wk2   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-wk2-stress   🛠 playstation
  🛠 tv   🧪 mac-intel-wk2   🛠 jsc-armv7
  🛠 tv-sim   🛠 mac-safer-cpp   🧪 jsc-armv7-tests
  🛠 watch
  🛠 watch-sim

darinadler
darinadler approved these changes Dec 2, 2025
View reviewed changes
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 2, 2025 •
edited
Loading

EWS run on previous version of this PR (hash ca95458)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 win
  🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 api-mac-debug ⏳ 🛠 wpe-cairo
  🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk1   🛠 gtk
  🛠 🧪 jsc-arm64   🛠 vision   🧪 mac-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-AS-debug-wk2   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-wk2-stress   🛠 playstation
  🛠 tv   🧪 mac-intel-wk2   🛠 jsc-armv7
  🛠 tv-sim   🛠 mac-safer-cpp   🧪 jsc-armv7-tests
  🛠 watch
  🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 2, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 8f02af4)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 win
  🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 api-mac-debug ⏳ 🛠 wpe-cairo
  🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk1   🛠 gtk
  🛠 🧪 jsc-arm64   🛠 vision   🧪 mac-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-AS-debug-wk2   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-wk2-stress   🛠 playstation
  🛠 tv   🧪 mac-intel-wk2   🛠 jsc-armv7
  🛠 tv-sim ✅ 🛠 mac-safer-cpp   🧪 jsc-armv7-tests
  🛠 watch
  🛠 watch-sim

@catamorphism catamorphism force-pushed the plainmonthday-plainyearmonth-part-9 branch from 8f02af4 to 05bddb7 Compare December 2, 2025 22:47
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 2, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 05bddb7)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 win
❌ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ⏳ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ❌ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
❌ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress ❌ 🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
❌ 🛠 tv-sim ✅ 🛠 mac-safer-cpp ✅ 🧪 jsc-armv7-tests
❌ 🛠 watch
✅ 🛠 watch-sim

@catamorphism catamorphism force-pushed the plainmonthday-plainyearmonth-part-9 branch from 05bddb7 to 3fba7ca Compare December 3, 2025 20:11
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 3, 2025 •
edited
Loading

EWS run on current version of this PR (hash 3fba7ca)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 api-mac-debug ⏳ 🛠 wpe-cairo
✅ 🛠 🧪 jsc   🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp   🧪 jsc-armv7-tests
  🛠 watch
✅ 🛠 watch-sim

@catamorphism catamorphism removed the merging-blocked Applied to prevent a change from being merged label Dec 3, 2025
@darinadler darinadler added the merge-queue Applied to send a pull request to merge-queue label Dec 3, 2025
@catamorphism @darinadler
[Temporal] Add toString, toJSON, and toLocaleString methods for Plain…
bf9ae75 
…YearMonth

https://bugs.webkit.org/show_bug.cgi?id=303413

Reviewed by Darin Adler.

Implement these methods.

Co-authored-by: Darin Adler <33187212+darinadler@users.noreply.github.com>

* JSTests/stress/temporal-plainyearmonth.js:
(shouldThrow):
* JSTests/test262/config.yaml:
* JSTests/test262/expectations.yaml:
* Source/JavaScriptCore/runtime/ISO8601.cpp:
(JSC::ISO8601::temporalYearMonthToString):
* Source/JavaScriptCore/runtime/ISO8601.h:
* Source/JavaScriptCore/runtime/TemporalPlainYearMonth.cpp:
(JSC::TemporalPlainYearMonth::toString const):
* Source/JavaScriptCore/runtime/TemporalPlainYearMonth.h:
* Source/JavaScriptCore/runtime/TemporalPlainYearMonthPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):

Canonical link: https://commits.webkit.org/303866@main
@webkit-commit-queue webkit-commit-queue force-pushed the plainmonthday-plainyearmonth-part-9 branch from 3fba7ca to bf9ae75 Compare December 3, 2025 22:47
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Dec 3, 2025

Committed 303866@main (bf9ae75): https://commits.webkit.org/303866@main

Reviewed commits have been landed. Closing PR #54717 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit bf9ae75 into WebKit:main Dec 3, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darinadler darinadler darinadler approved these changes

Assignees

@catamorphism catamorphism

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@catamorphism @webkit-early-warning-system @webkit-commit-queue @darinadler @webkit-ews-buildbot