Temporal: Implement valueOf for PlainMonthDay objects #54563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
EWS run on current version of this PR (hash 469f6ea) Details |
ptomato
approved these changes
Nov 28, 2025
Contributor
ptomato
left a comment
There was a problem hiding this comment.
I'm not a reviewer, but this does implement the intended functionality 😄
Comment on lines
+113
to
+116
| shouldBe(Temporal.PlainMonthDay.prototype.valueOf.length, 0); | ||
| { | ||
| shouldThrow(() => monthDay.valueOf(), TypeError); | ||
| } |
Contributor
There was a problem hiding this comment.
These things are definitely covered in test262 already, though I don't know what the policy is for duplicating coverage in JSTests.
Contributor
Author
There was a problem hiding this comment.
I've assumed there needs to be a stress test for each commit, but someone correct me if I'm wrong?
justinmichaud
approved these changes
Nov 28, 2025
https://bugs.webkit.org/show_bug.cgi?id=303243 Reviewed by Justin Michaud. Implement valueOf for PlainMonthDay (which always throws). Also enable a test for PlainDate that passes, which somehow wasn't enabled in the previous Temporal PR. * JSTests/stress/temporal-plainmonthday.js: (shouldBe): * JSTests/test262/config.yaml: * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/runtime/TemporalPlainMonthDayPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): Canonical link: https://commits.webkit.org/303631@main
469f6ea to
883b821
Compare
Collaborator
|
Committed 303631@main (883b821): https://commits.webkit.org/303631@main Reviewed commits have been landed. Closing PR #54563 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
883b821
469f6ea
🧪 win-tests🧪 ios-wk2🛠 playstation🧪 jsc-armv7-tests