Skip to content

[WPE] Right mouse button click stops further mouse button processing #54398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Nov 25, 2025
Merged

[WPE] Right mouse button click stops further mouse button processing #54398

webkit-commit-queue merged 1 commit into from
Nov 25, 2025

Conversation

@kate-k-lee
Copy link
Contributor

@kate-k-lee kate-k-lee commented Nov 24, 2025 •
edited by webkit-early-warning-system
Loading

d811b27

[WPE] Right mouse button click stops further mouse button processing

https://bugs.webkit.org/show_bug.cgi?id=272354

Reviewed by Adrian Perez de Castro.

The context menu request was not followed by any
implementation logic. As a result, WebPageProxy::
clearWaitingForContextMenuToShow() was never called,
leaving the page stuck in a state where mouse click
events were not processed.

This patch introduces the initial plumbing for WPE
context menu handling. Follow-up patches will impl-
ement the full public API to expose hit-test results
and context-menu item information to the application.

This patch is based on the original work by
chrisduerr@. I have updated the work for the WPE port.

Co-authored-by: Christian Duerr(chrisduerr@)<contact@christianduerr.com>

* Source/WebKit/SourcesWPE.txt:
* Source/WebKit/UIProcess/wpe/WebContextMenuProxyWPE.cpp: Copied from Source/WebKit/UIProcess/wpe/WebContextMenuProxyWPE.h.
(WebKit::WebContextMenuProxyWPE::WebContextMenuProxyWPE):
(WebKit::WebContextMenuProxyWPE::showContextMenuWithItems):
* Source/WebKit/UIProcess/wpe/WebContextMenuProxyWPE.h:

Canonical link: https://commits.webkit.org/303518@main

1a7c5b0

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@kate-k-lee kate-k-lee requested a review from a team as a code owner November 24, 2025 04:52
@kate-k-lee kate-k-lee self-assigned this Nov 24, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 24, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 249a92e)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@kate-k-lee kate-k-lee added the WPE WebKit WebKit WPE component label Nov 24, 2025
@chrisduerr
Copy link
Contributor

chrisduerr commented Nov 24, 2025

Been running this patch (with a little extra) for several months now (chrisduerr@33926f4) and can definitely confirm it fixes https://bugs.webkit.org/show_bug.cgi?id=272354#c7 for me.

carlosgcampos
carlosgcampos reviewed Nov 24, 2025
View reviewed changes
@kate-k-lee kate-k-lee force-pushed the eng/WPE-Right-mouse-button-click-stops-further-mouse-button-processing branch from 249a92e to 1a7c5b0 Compare November 24, 2025 14:19
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 24, 2025 •
edited
Loading

EWS run on current version of this PR (hash 1a7c5b0)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-wk2-stress   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 mac-intel-wk2
✅ 🛠 tv-sim ✅ 🛠 mac-safer-cpp
✅ 🛠 watch
✅ 🛠 watch-sim

@kate-k-lee kate-k-lee changed the title [WPE] Fix missing context menu handling causing [WPE] Right mouse button click stops further mouse button processing Nov 24, 2025
@kate-k-lee
Copy link
Contributor Author

kate-k-lee commented Nov 24, 2025

@chrisduerr Thanks a lot for confirming, and also for the initial work you did on this issue.
Your earlier patch was very helpful — I picked it up and built on top of it to proceed the WPE implementation. I also added you as a co-author in the commit to make sure the credit for your original contribution is properly preserved.

Thanks again for laying the groundwork!

@fujii fujii added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 25, 2025
@kate-k-lee @fujii
[WPE] Right mouse button click stops further mouse button processing
d811b27 
https://bugs.webkit.org/show_bug.cgi?id=272354

Reviewed by Adrian Perez de Castro.

The context menu request was not followed by any
implementation logic. As a result, WebPageProxy::
clearWaitingForContextMenuToShow() was never called,
leaving the page stuck in a state where mouse click
events were not processed.

This patch introduces the initial plumbing for WPE
context menu handling. Follow-up patches will impl-
ement the full public API to expose hit-test results
and context-menu item information to the application.

This patch is based on the original work by
chrisduerr@. I have updated the work for the WPE port.

Co-authored-by: Christian Duerr(chrisduerr@)<contact@christianduerr.com>

* Source/WebKit/SourcesWPE.txt:
* Source/WebKit/UIProcess/wpe/WebContextMenuProxyWPE.cpp: Copied from Source/WebKit/UIProcess/wpe/WebContextMenuProxyWPE.h.
(WebKit::WebContextMenuProxyWPE::WebContextMenuProxyWPE):
(WebKit::WebContextMenuProxyWPE::showContextMenuWithItems):
* Source/WebKit/UIProcess/wpe/WebContextMenuProxyWPE.h:

Canonical link: https://commits.webkit.org/303518@main
@webkit-commit-queue webkit-commit-queue changed the title [WPE] Right mouse button click stops further mouse button processing [WPE] Right mouse button click stops further mouse button processing Nov 25, 2025
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WPE-Right-mouse-button-click-stops-further-mouse-button-processing branch from 1a7c5b0 to d811b27 Compare November 25, 2025 00:10
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Nov 25, 2025

Committed 303518@main (d811b27): https://commits.webkit.org/303518@main

Reviewed commits have been landed. Closing PR #54398 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d811b27 into WebKit:main Nov 25, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 25, 2025
@aperezdc aperezdc added the GLib Suggested Backport - 2.50 Suggest this merge request be backported to webkitglib/2.50 branch label Nov 25, 2025
@aperezdc
Copy link
Contributor

aperezdc commented Nov 25, 2025

Backported into webkitglib/2.50 as commit aa6b024

@aperezdc aperezdc removed the GLib Suggested Backport - 2.50 Suggest this merge request be backported to webkitglib/2.50 branch label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosgcampos carlosgcampos carlosgcampos left review comments

@aperezdc aperezdc aperezdc approved these changes

Assignees

@kate-k-lee kate-k-lee

Labels

WPE WebKit WebKit WPE component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kate-k-lee @webkit-early-warning-system @chrisduerr @webkit-commit-queue @aperezdc @carlosgcampos @fujii