Skip to content

[GTK][WPE][OpenXR] Run monado-service w/o stdin for API tests #52114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Oct 10, 2025
Merged

[GTK][WPE][OpenXR] Run monado-service w/o stdin for API tests #52114

webkit-commit-queue merged 1 commit into from
Oct 10, 2025

Conversation

@spenap
Copy link
Contributor

@spenap spenap commented Oct 10, 2025 •
edited by webkit-early-warning-system
Loading

34ac3ce

[GTK][WPE][OpenXR] Run monado-service w/o stdin for API tests
https://bugs.webkit.org/show_bug.cgi?id=300500

Reviewed by Adrian Perez de Castro.

Ensure XRT_NO_STDIN is set by the monado driver so that it is only
stopped by the test runner when the tests have finished running. This
allows us to unskip some of the WebXR API tests.

* Tools/Scripts/webkitpy/port/monadodriver.py:
(MonadoDriver._setup_environ_for_test): set XRT_NO_STDIN as the test
environment.
* Tools/TestWebKitAPI/glib/TestExpectations.json: Unskip
  leave-immersive-mode for GTK and WPE.

Canonical link: https://commits.webkit.org/301313@main

412dce0

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 💥 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 loading 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@spenap spenap requested review from a team, JonWBedard and gsnedders as code owners October 10, 2025 10:32
@spenap spenap self-assigned this Oct 10, 2025
@spenap spenap added the WebKitGTK Bugs related to the Gtk API layer. label Oct 10, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 10, 2025 •
edited
Loading

EWS run on current version of this PR (hash 412dce0)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 💥 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 loading 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@spenap spenap mentioned this pull request Oct 10, 2025
Closed
@spenap spenap added the merge-queue Applied to send a pull request to merge-queue label Oct 10, 2025
@spenap
[GTK][WPE][OpenXR] Run monado-service w/o stdin for API tests
34ac3ce 
https://bugs.webkit.org/show_bug.cgi?id=300500

Reviewed by Adrian Perez de Castro.

Ensure XRT_NO_STDIN is set by the monado driver so that it is only
stopped by the test runner when the tests have finished running. This
allows us to unskip some of the WebXR API tests.

* Tools/Scripts/webkitpy/port/monadodriver.py:
(MonadoDriver._setup_environ_for_test): set XRT_NO_STDIN as the test
environment.
* Tools/TestWebKitAPI/glib/TestExpectations.json: Unskip
  leave-immersive-mode for GTK and WPE.

Canonical link: https://commits.webkit.org/301313@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/GTK-WPE-OpenXR-Run-monado-service-w-o-stdin-for-API-tests branch from 412dce0 to 34ac3ce Compare October 10, 2025 14:20
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Oct 10, 2025

Committed 301313@main (34ac3ce): https://commits.webkit.org/301313@main

Reviewed commits have been landed. Closing PR #52114 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 34ac3ce into WebKit:main Oct 10, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 10, 2025
@spenap spenap deleted the eng/GTK-WPE-OpenXR-Run-monado-service-w-o-stdin-for-API-tests branch October 13, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aperezdc aperezdc aperezdc approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

@gsnedders gsnedders Awaiting requested review from gsnedders gsnedders is a code owner

Assignees

@spenap spenap

Labels

WebKitGTK Bugs related to the Gtk API layer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spenap @webkit-early-warning-system @webkit-commit-queue @aperezdc