Skip to content

Digital Credentials: implement userAgentAllowsProtocol()#47283

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
marcoscaceres:eng/Digital-Credentials-implement-userAgentAllowsProtocol
Jun 30, 2025
Merged

Digital Credentials: implement userAgentAllowsProtocol()#47283
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
marcoscaceres:eng/Digital-Credentials-implement-userAgentAllowsProtocol

Conversation

@marcoscaceres

@marcoscaceres marcoscaceres commented Jun 27, 2025 •
edited by webkit-early-warning-system
Loading

Copy link
Copy Markdown
Contributor

13d1709

Digital Credentials: implement userAgentAllowsProtocol()
rdar://153776127
https://bugs.webkit.org/show_bug.cgi?id=294352

Reviewed by Anne van Kesteren.

This implements the userAgentAllowsProtocol() method, which allows
user agents to indicate whether they support a given protocol for
digital credentials. This is useful for sites to determine if they can
request a digital credential with a specific protocol.

Spec:
https://w3c-fedid.github.io/digital-credentials/#dom-digitalcredential-useragentallowsprotocol

WebKit only supports the "org-iso-mdoc" protocol, so this method
returns true only for that protocol.

Imports relevent Web Platform Tests. Upstream commit:

web-platform-tests/wpt@c7fd2ce
Canonical link: https://commits.webkit.org/296786@main

ed3f83f

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@marcoscaceres marcoscaceres self-assigned this Jun 27, 2025
@webkit-early-warning-system

webkit-early-warning-system commented Jun 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on previous version of this PR (hash 4fe3b55)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2   🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@marcoscaceres marcoscaceres force-pushed the eng/Digital-Credentials-implement-userAgentAllowsProtocol branch from 4fe3b55 to ed3f83f Compare June 27, 2025 08:32
@webkit-early-warning-system

webkit-early-warning-system commented Jun 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on current version of this PR (hash ed3f83f)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@marcoscaceres marcoscaceres mentioned this pull request Jun 27, 2025
Merged
9 tasks
annevk
annevk approved these changes Jun 27, 2025
View reviewed changes
Comment thread Source/WebCore/Modules/identity/DigitalCredential.idl Outdated

@annevk annevk Jun 27, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually put static members first.

@marcoscaceres marcoscaceres added the merge-queue Applied to send a pull request to merge-queue label Jun 30, 2025
@marcoscaceres
Digital Credentials: implement userAgentAllowsProtocol()
13d1709 
rdar://153776127
https://bugs.webkit.org/show_bug.cgi?id=294352

Reviewed by Anne van Kesteren.

This implements the userAgentAllowsProtocol() method, which allows
user agents to indicate whether they support a given protocol for
digital credentials. This is useful for sites to determine if they can
request a digital credential with a specific protocol.

Spec:
https://w3c-fedid.github.io/digital-credentials/#dom-digitalcredential-useragentallowsprotocol

WebKit only supports the "org-iso-mdoc" protocol, so this method
returns true only for that protocol.

Imports relevent Web Platform Tests. Upstream commit:

web-platform-tests/wpt@c7fd2ce
Canonical link: https://commits.webkit.org/296786@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Digital-Credentials-implement-userAgentAllowsProtocol branch from ed3f83f to 13d1709 Compare June 30, 2025 03:18
@webkit-commit-queue

webkit-commit-queue commented Jun 30, 2025

Copy link
Copy Markdown
Collaborator

Committed 296786@main (13d1709): https://commits.webkit.org/296786@main

Reviewed commits have been landed. Closing PR #47283 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 13d1709 into WebKit:main Jun 30, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 30, 2025
@marcoscaceres marcoscaceres deleted the eng/Digital-Credentials-implement-userAgentAllowsProtocol branch July 7, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annevk annevk annevk approved these changes

Assignees

@marcoscaceres marcoscaceres

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marcoscaceres @webkit-early-warning-system @webkit-commit-queue @annevk