Skip to content

Annotate SetMockWebAuthenticationConfiguration endpoint with AllowTestOnlyIPC#43594

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
robert-jenner:eng/148058467
Apr 14, 2025
Merged

Annotate SetMockWebAuthenticationConfiguration endpoint with AllowTestOnlyIPC#43594
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
robert-jenner:eng/148058467

Conversation

@robert-jenner

@robert-jenner robert-jenner commented Apr 3, 2025 •
edited by webkit-early-warning-system
Loading

Copy link
Copy Markdown
Contributor

33084aa

Annotate SetMockWebAuthenticationConfiguration endpoint with AllowTestOnlyIPC
https://bugs.webkit.org/show_bug.cgi?id=287249
rdar://144224078

Reviewed by Sihui Liu and Ryosuke Niwa.

Annotate SetMockWebAuthenticationConfiguration endpoint with AllowTestOnlyIPC

* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

Originally-landed-as: 289651.122@safari-7621-branch (187eb9fbee7c). rdar://148058467
Canonical link: https://commits.webkit.org/293668@main

bd8ba4e

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@robert-jenner robert-jenner self-assigned this Apr 3, 2025
@webkit-early-warning-system

webkit-early-warning-system commented Apr 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on previous version of this PR (hash 2cabb09)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🧪 api-wpe
✅ 🧪 webkitpy ❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ❌ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ❌ 🧪 api-ios ❌ 🧪 mac-wk2 ❌ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ❌ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
❌ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
⏳ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ✅ 🛠 playstation
❌ 🛠 tv ❌ 🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
❌ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
❌ 🛠 watch
❌ 🛠 watch-sim

@robert-jenner robert-jenner added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Apr 3, 2025
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 4, 2025
@robert-jenner robert-jenner removed the merging-blocked Applied to prevent a change from being merged label Apr 9, 2025
@webkit-early-warning-system

webkit-early-warning-system commented Apr 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on previous version of this PR (hash fd5a30e)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ❌ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64   🛠 vision ❌ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
❌ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv   🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 9, 2025
@robert-jenner robert-jenner removed the merging-blocked Applied to prevent a change from being merged label Apr 9, 2025
@webkit-early-warning-system

webkit-early-warning-system commented Apr 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on previous version of this PR (hash 164a067)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
❌ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
❌ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
❌ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
⏳ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ❌ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 9, 2025
@robert-jenner robert-jenner removed the merging-blocked Applied to prevent a change from being merged label Apr 11, 2025
@webkit-early-warning-system

webkit-early-warning-system commented Apr 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

EWS run on current version of this PR (hash bd8ba4e)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 12, 2025
@webkit-ews-buildbot

webkit-ews-buildbot commented Apr 12, 2025

Copy link
Copy Markdown
Collaborator

Failed ios-wk2, mac-AS-debug-wk2 checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #43594 from merge queue.

@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Apr 12, 2025
@webkit-ews-buildbot

webkit-ews-buildbot commented Apr 12, 2025

Copy link
Copy Markdown
Collaborator

Safe-Merge-Queue: Build #54246.

@robert-jenner robert-jenner added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Apr 14, 2025
@darryl-apple @robert-jenner
Annotate SetMockWebAuthenticationConfiguration endpoint with AllowTes…
33084aa 
…tOnlyIPC

https://bugs.webkit.org/show_bug.cgi?id=287249
rdar://144224078

Reviewed by Sihui Liu and Ryosuke Niwa.

Annotate SetMockWebAuthenticationConfiguration endpoint with AllowTestOnlyIPC

* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

Originally-landed-as: 289651.122@safari-7621-branch (187eb9f). rdar://148058467
Canonical link: https://commits.webkit.org/293668@main
@webkit-commit-queue

webkit-commit-queue commented Apr 14, 2025

Copy link
Copy Markdown
Collaborator

Committed 293668@main (33084aa): https://commits.webkit.org/293668@main

Reviewed commits have been landed. Closing PR #43594 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 33084aa into WebKit:main Apr 14, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@b-weinstein b-weinstein Awaiting requested review from b-weinstein

@xeenon xeenon Awaiting requested review from xeenon

@rniwa rniwa Awaiting requested review from rniwa

Assignees

@robert-jenner robert-jenner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@robert-jenner @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @darryl-apple