BBQ FusedIf should propagate allocated scratch register to new block#43522
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 642f753) Details |
642f753 to
cec3cb9
Compare
Collaborator
|
EWS run on current version of this PR (hash cec3cb9) Details |
Collaborator
|
Safe-Merge-Queue: Build #53452. |
rdar://142965165 Reviewed by Chris Dumez and Eric Carlson. Make sure to use alpha row size to compute storage size instead of relying on the size being the same as plane A. We also fix an issue in SharedVideoFrameInfo::decode where we were not checking for planeAlpha size being correctly decoded. Covered by added unit test. * Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm: (WebCore::SharedVideoFrameInfo::storageSize const): (WebCore::SharedVideoFrameInfo::decode): * Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: * Tools/TestWebKitAPI/Tests/WebCore/cocoa/SharedVideoFrame.mm: Added. (TestWebKitAPI::TEST(WebCore, SharedVideoFramePlaneAlphaSize)): Originally-landed-as: 283286.629@safari-7620-branch (55b915bbbe64). rdar://148113842 Canonical link: https://commits.webkit.org/293226@main
https://bugs.webkit.org/show_bug.cgi?id=286462 rdar://142276253 Reviewed by Darin Adler. * LayoutTests/fast/css/transform-translate-parsing-crash-expected.txt: Added. * LayoutTests/fast/css/transform-translate-parsing-crash.html: Added. * Source/WebCore/css/parser/CSSParserFastPaths.cpp: (WebCore::parseSimpleTransformValue): Check we don't access out of bounds indexes. Originally-landed-as: 283286.630@safari-7620-branch (c09afb6b82bf). rdar://148113678 Canonical link: https://commits.webkit.org/293227@main
…scation rdar://142170054 Reviewed by Brady Eidson. According to spec (https://w3c.github.io/IndexedDB/#upgrade-transaction-construct), version change (or upgrade) transaction has exclusive access to database. The current implementation enforces this on client side (web process) by not adding new transaction on server when there is ongoing version change transaction. This patch adds this check to server side since web process could be compromised and schedule transactions unexpectedly. * Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp: (WebCore::IDBServer::UniqueIDBDatabase::takeNextRunnableTransaction): Originally-landed-as: 283286.631@safari-7620-branch (43d9bdf80277). rdar://148113398 Canonical link: https://commits.webkit.org/293228@main
https://bugs.webkit.org/show_bug.cgi?id=286512 rdar://142474221 Reviewed by Yusuke Suzuki. Since FusedIf allocates a scratch register, the new block created by FusedIf needs to be aware of this allocation, or else it may try to allocate another register in the same place. * Source/JavaScriptCore/wasm/WasmBBQJIT64.cpp: (JSC::Wasm::BBQJITImpl::BBQJIT::addFusedIfCompare): Originally-landed-as: 283286.632@safari-7620-branch (4af308c795b6). rdar://148112940 Canonical link: https://commits.webkit.org/293229@main
cec3cb9 to
748ddee
Compare
Collaborator
|
Committed 293229@main (748ddee): https://commits.webkit.org/293229@main Reviewed commits have been landed. Closing PR #43522 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
748ddee
bc947c0
575e580
68444c0
cec3cb9