[WebAudio] Implement AudioContext::outputLatency by jyavenard · Pull Request #38923 · WebKit/WebKit

jyavenard · 2025-01-13T10:07:31Z

`420f89a`

[WebAudio] Implement AudioContext::outputLatency
https://bugs.webkit.org/show_bug.cgi?id=285826
rdar://142794341

Reviewed by Youenn Fablet.

Add implementation for Cocoa platforms, other platforms will return 0 for now.

* LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt:
* Source/WebCore/Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::outputLatency):
* Source/WebCore/Modules/webaudio/AudioContext.h:
* Source/WebCore/Modules/webaudio/AudioContext.idl:
* Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::outputLatency const):
* Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:
* Source/WebCore/platform/audio/AudioDestination.h:
(WebCore::AudioDestination::outputLatency const):
* Source/WebCore/platform/audio/AudioSession.h:
* Source/WebCore/platform/audio/SharedAudioDestination.cpp:
(WebCore::SharedAudioDestinationAdapter::outputLatency const):
(WebCore::SharedAudioDestinationAdapter::protectedDestination const):
(WebCore::SharedAudioDestination::outputLatency const):
(WebCore::SharedAudioDestination::protectedOutputAdapter const):
(WebCore::SharedAudioDestinationAdapter::protectedDestination): Deleted.
(WebCore::SharedAudioDestination::protectedOutputAdapter): Deleted.
* Source/WebCore/platform/audio/SharedAudioDestination.h:
* Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.cpp:
(WebCore::AudioDestinationCocoa::outputLatency const):
* Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.h:
* Source/WebCore/platform/audio/cocoa/AudioOutputUnitAdaptor.cpp:
(WebCore::AudioOutputUnitAdaptor::outputLatency const):
* Source/WebCore/platform/audio/cocoa/AudioOutputUnitAdaptor.h:
* Source/WebCore/platform/audio/ios/AudioSessionIOS.h:
* Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSessionIOS::outputLatency const):
* Source/WebCore/platform/audio/mac/AudioSessionMac.h:
* Source/WebCore/platform/audio/mac/AudioSessionMac.mm:
(WebCore::AudioSessionMac::outputLatency const):
* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:
(WebKit::RemoteAudioDestinationManager::createAudioDestination):
(WebKit::RemoteAudioDestinationManager::startAudioDestination):
* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.h:
* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.messages.in:
* Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp:
(WebKit::RemoteAudioSessionProxy::configuration):
* Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp:
(WebKit::RemoteAudioDestinationProxy::connection):
(WebKit::RemoteAudioDestinationProxy::startRendering):
(WebKit::RemoteAudioDestinationProxy::outputLatency const):
* Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.h:
* Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.h:
* Source/WebKit/WebProcess/GPU/media/RemoteAudioSessionConfiguration.h:
* Source/WebKit/WebProcess/GPU/media/RemoteAudioSessionConfiguration.serialization.in:

Canonical link: https://commits.webkit.org/288904@main

a575fca

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	~~🧪 api-wpe~~
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	~~🛠 watch-sim~~

webkit-early-warning-system · 2025-01-13T10:07:38Z

EWS run on previous version of this PR (hash 508e4ab)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	❌ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	❌ 🛠 wpe-cairo
	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	❌ 🛠 gtk
	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	❌ 🧪 api-gtk
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~	✅ 🛠 playstation
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-01-13T10:31:34Z

EWS run on previous version of this PR (hash 0ab4a63)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🛠 wpe-cairo
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-01-14T00:42:26Z

EWS run on previous version of this PR (hash c5d7ea4)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	~~🛠 ios-sim~~	~~🛠 mac-AS-debug~~	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
	~~🛠 vision~~	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~	~~🛠 playstation~~
	~~🛠 tv~~	~~🛠 mac-safer-cpp~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2025-01-14T00:45:05Z

EWS run on previous version of this PR (hash f2267bb)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	✅ 🧪 win-tests
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	⏳ 🧪 api-gtk
	~~🧪 vision-wk2~~	⏳ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	~~🛠 tv-sim~~
	✅ 🛠 watch
	~~🛠 watch-sim~~

whsieh · 2025-01-14T00:56:07Z

I think you could go down this codepath in both cases (Minimal and Enhanced)

Suggested change

if (noiseInjectionPolicies().contains(NoiseInjectionPolicy::Minimal))

if (noiseInjectionPolicies())

webkit-early-warning-system · 2025-01-14T01:53:51Z

EWS run on previous version of this PR (hash 088fb33)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

youennf · 2025-01-14T10:18:21Z

Would it be better to leave destination do this computation?
That way, we can do the computation in GPUProcess and remove the need to send to WebProcess the audio session latency.

Doing so would require to have a way for the RemoteAudioDestination/RemoteAudioDestinationProxy be notified when the AudioSession changes. It's a much bigger change.

And currently the RemoteAudioSession in the WebContent is being notified of changes of AudioSession in the GPU process. So I re-used that.

it made the change much smaller.

I could move that arithmetic in the AudioDestination, but then it kind of blur which latency are we talking about. The AudioDestination itself, the AudioSession, both?

I would prefer we would move the computation to the AudioDestination.
It is probably the audio destination that will handle setSinkId computation as well, so that seems better this way.

youennf · 2025-01-14T10:50:44Z

I would tend to move this computation to AudioOuptutUnitAdaptor.
The reason is that AudioContext can be set to a particular device via setSinkId.

To handle the case of audio context playing on the device device and default device is changing, AudioOuptutUnitAdaptor would ideally be notified that the default device is changing and would do the recomputation if it is not set to a particular device via setSinkId.
And then send the updated value to its AudioOuptutUnitAdaptor client.

We don't currently support setSinkId on the AudioContext so I will take this as a follow-up.

I also don't see how we can retrieve the device's latency from the AudioUnit

youennf

r=me.
I would tend to have AudioDestination be the one to do the latency computation.
This eases handling the case of not playing context as well as future setSinkId case.

youennf · 2025-01-14T12:35:34Z

It seems odd to return the audiosession latency even if AudioContext is not playing.
I'll tend to move the logic to add the latencies in destination.

Limited it to when the context is playing

youennf · 2025-01-14T12:36:46Z

I would prefer we would move the computation to the AudioDestination.
It is probably the audio destination that will handle setSinkId computation as well, so that seems better this way.

webkit-early-warning-system · 2025-01-14T23:00:56Z

EWS run on previous version of this PR (hash 6b74781)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	⏳ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	⏳ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	~~🛠 watch-sim~~

webkit-early-warning-system · 2025-01-14T23:59:06Z

EWS run on current version of this PR (hash a575fca)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	~~🧪 api-wpe~~
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	~~🛠 watch-sim~~

https://bugs.webkit.org/show_bug.cgi?id=285826 rdar://142794341 Reviewed by Youenn Fablet. Add implementation for Cocoa platforms, other platforms will return 0 for now. * LayoutTests/imported/w3c/web-platform-tests/webaudio/idlharness.https.window-expected.txt: * Source/WebCore/Modules/webaudio/AudioContext.cpp: (WebCore::AudioContext::outputLatency): * Source/WebCore/Modules/webaudio/AudioContext.h: * Source/WebCore/Modules/webaudio/AudioContext.idl: * Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp: (WebCore::DefaultAudioDestinationNode::outputLatency const): * Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h: * Source/WebCore/platform/audio/AudioDestination.h: (WebCore::AudioDestination::outputLatency const): * Source/WebCore/platform/audio/AudioSession.h: * Source/WebCore/platform/audio/SharedAudioDestination.cpp: (WebCore::SharedAudioDestinationAdapter::outputLatency const): (WebCore::SharedAudioDestinationAdapter::protectedDestination const): (WebCore::SharedAudioDestination::outputLatency const): (WebCore::SharedAudioDestination::protectedOutputAdapter const): (WebCore::SharedAudioDestinationAdapter::protectedDestination): Deleted. (WebCore::SharedAudioDestination::protectedOutputAdapter): Deleted. * Source/WebCore/platform/audio/SharedAudioDestination.h: * Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.cpp: (WebCore::AudioDestinationCocoa::outputLatency const): * Source/WebCore/platform/audio/cocoa/AudioDestinationCocoa.h: * Source/WebCore/platform/audio/cocoa/AudioOutputUnitAdaptor.cpp: (WebCore::AudioOutputUnitAdaptor::outputLatency const): * Source/WebCore/platform/audio/cocoa/AudioOutputUnitAdaptor.h: * Source/WebCore/platform/audio/ios/AudioSessionIOS.h: * Source/WebCore/platform/audio/ios/AudioSessionIOS.mm: (WebCore::AudioSessionIOS::outputLatency const): * Source/WebCore/platform/audio/mac/AudioSessionMac.h: * Source/WebCore/platform/audio/mac/AudioSessionMac.mm: (WebCore::AudioSessionMac::outputLatency const): * Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp: (WebKit::RemoteAudioDestinationManager::createAudioDestination): (WebKit::RemoteAudioDestinationManager::startAudioDestination): * Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.h: * Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.messages.in: * Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp: (WebKit::RemoteAudioSessionProxy::configuration): * Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp: (WebKit::RemoteAudioDestinationProxy::connection): (WebKit::RemoteAudioDestinationProxy::startRendering): (WebKit::RemoteAudioDestinationProxy::outputLatency const): * Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.h: * Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.h: * Source/WebKit/WebProcess/GPU/media/RemoteAudioSessionConfiguration.h: * Source/WebKit/WebProcess/GPU/media/RemoteAudioSessionConfiguration.serialization.in: Canonical link: https://commits.webkit.org/288904@main

webkit-commit-queue · 2025-01-15T00:57:43Z

Committed 288904@main (420f89a): https://commits.webkit.org/288904@main

Reviewed commits have been landed. Closing PR #38923 and removing active labels.

jyavenard requested a review from cdumez as a code owner January 13, 2025 10:07

jyavenard self-assigned this Jan 13, 2025

jyavenard added the Web Audio Bugs against the Web Audio API label Jan 13, 2025

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 13, 2025

jyavenard removed the merging-blocked Applied to prevent a change from being merged label Jan 13, 2025

jyavenard force-pushed the eng/WebAudio-Implement-AudioContext-outputLatency branch from 508e4ab to 0ab4a63 Compare January 13, 2025 10:31

jyavenard requested review from jernoble and youennf January 13, 2025 10:32

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 13, 2025

jyavenard removed the merging-blocked Applied to prevent a change from being merged label Jan 14, 2025

jyavenard force-pushed the eng/WebAudio-Implement-AudioContext-outputLatency branch from 0ab4a63 to c5d7ea4 Compare January 14, 2025 00:42

jyavenard force-pushed the eng/WebAudio-Implement-AudioContext-outputLatency branch from c5d7ea4 to f2267bb Compare January 14, 2025 00:44

whsieh reviewed Jan 14, 2025

View reviewed changes

jyavenard force-pushed the eng/WebAudio-Implement-AudioContext-outputLatency branch from f2267bb to 088fb33 Compare January 14, 2025 01:53

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 14, 2025

youennf reviewed Jan 14, 2025

View reviewed changes

youennf approved these changes Jan 14, 2025

View reviewed changes

jyavenard removed the merging-blocked Applied to prevent a change from being merged label Jan 14, 2025

jyavenard force-pushed the eng/WebAudio-Implement-AudioContext-outputLatency branch from 088fb33 to 6b74781 Compare January 14, 2025 23:00

jyavenard force-pushed the eng/WebAudio-Implement-AudioContext-outputLatency branch from 6b74781 to a575fca Compare January 14, 2025 23:59

jyavenard added the merge-queue Applied to send a pull request to merge-queue label Jan 15, 2025

webkit-commit-queue force-pushed the eng/WebAudio-Implement-AudioContext-outputLatency branch from a575fca to 420f89a Compare January 15, 2025 00:57

webkit-commit-queue merged commit 420f89a into WebKit:main Jan 15, 2025

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 15, 2025

caugner mentioned this pull request May 9, 2025

Safari 18.4 adds AudioContext.outputLatency mdn/browser-compat-data#26741

Merged

	if (noiseInjectionPolicies().contains(NoiseInjectionPolicy::Minimal))
	if (noiseInjectionPolicies())

Conversation

jyavenard commented Jan 13, 2025 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

youennf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webkit-early-warning-system commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Jan 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jyavenard commented Jan 13, 2025 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Jan 13, 2025 •

edited

Loading

webkit-early-warning-system commented Jan 13, 2025 •

edited

Loading

webkit-early-warning-system commented Jan 14, 2025 •

edited

Loading

webkit-early-warning-system commented Jan 14, 2025 •

edited

Loading

webkit-early-warning-system commented Jan 14, 2025 •

edited

Loading

webkit-early-warning-system commented Jan 14, 2025 •

edited

Loading

webkit-early-warning-system commented Jan 14, 2025 •

edited

Loading