Skip to content

Use clang-cl for assembling offlineasm on Windows#28538

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
iangrunert:ig/use-clang-offlineasm-win
May 14, 2024
Merged

Use clang-cl for assembling offlineasm on Windows#28538
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
iangrunert:ig/use-clang-offlineasm-win

Conversation

@iangrunert
Copy link
Contributor

@iangrunert iangrunert commented May 14, 2024 •
edited by webkit-early-warning-system
Loading

45da615

Use clang-cl for assembling offlineasm on Windows
https://bugs.webkit.org/show_bug.cgi?id=274154

Reviewed by Yusuke Suzuki.

Switched to the LLIntAssembly.h output approach for offlineasm on
Windows. Cleanup of dead code in asm.rb and x86.rb left for a future
change to make this easier to review and land.

* Source/JavaScriptCore/CMakeLists.txt:
* Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:
* Source/JavaScriptCore/offlineasm/asm.rb:
* Source/JavaScriptCore/offlineasm/x86.rb:
* Source/WTF/wtf/InlineASM.h:
* Source/cmake/OptionsMSVC.cmake:
* Source/cmake/OptionsWin.cmake:

Canonical link: https://commits.webkit.org/278767@main

3d832cc

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ⏳ 🛠 wpe-skia
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

@iangrunert iangrunert requested a review from a team as a code owner May 14, 2024 14:48
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 14, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 98ba374)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ❌ 🛠 wincairo
❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🧪 api-wpe
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ⏳ 🛠 wpe-skia
❌ 🛠 🧪 jsc ❌ 🧪 api-ios ❌ 🧪 mac-wk2 ❌ 🛠 gtk
❌ 🛠 🧪 jsc-arm64 ❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
❌ 🛠 tv-sim ❌ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
❌ 🛠 watch ❌ 🛠 jsc-armv7
❌ 🛠 watch-sim ❌ 🧪 jsc-armv7-tests

@iangrunert iangrunert added CMake Bugzilla component for CMake build system changes JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. labels May 14, 2024
@iangrunert iangrunert self-assigned this May 14, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 14, 2024
@iangrunert iangrunert force-pushed the ig/use-clang-offlineasm-win branch from 98ba374 to 3d832cc Compare May 14, 2024 14:58
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 14, 2024 •
edited
Loading

EWS run on current version of this PR (hash 3d832cc)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ⏳ 🛠 wpe-skia
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 watch ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-armv7-tests

@Constellation Constellation removed the merging-blocked Applied to prevent a change from being merged label May 14, 2024
Constellation
Constellation approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 14, 2024
@iangrunert @Constellation
Use clang-cl for assembling offlineasm on Windows
45da615 
https://bugs.webkit.org/show_bug.cgi?id=274154

Reviewed by Yusuke Suzuki.

Switched to the LLIntAssembly.h output approach for offlineasm on
Windows. Cleanup of dead code in asm.rb and x86.rb left for a future
change to make this easier to review and land.

* Source/JavaScriptCore/CMakeLists.txt:
* Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:
* Source/JavaScriptCore/offlineasm/asm.rb:
* Source/JavaScriptCore/offlineasm/x86.rb:
* Source/WTF/wtf/InlineASM.h:
* Source/cmake/OptionsMSVC.cmake:
* Source/cmake/OptionsWin.cmake:

Canonical link: https://commits.webkit.org/278767@main
@webkit-commit-queue webkit-commit-queue force-pushed the ig/use-clang-offlineasm-win branch from 3d832cc to 45da615 Compare May 14, 2024 16:57
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented May 14, 2024

Committed 278767@main (45da615): https://commits.webkit.org/278767@main

Reviewed commits have been landed. Closing PR #28538 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 45da615 into WebKit:main May 14, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 14, 2024
@iangrunert iangrunert mentioned this pull request May 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Constellation Constellation Constellation approved these changes

Assignees

@iangrunert iangrunert

Labels

CMake Bugzilla component for CMake build system changes JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iangrunert @webkit-early-warning-system @webkit-commit-queue @Constellation @webkit-ews-buildbot