Assign generic role to aside tag within the sectioning content elements by joone · Pull Request #20013 · WebKit/WebKit

joone · 2023-11-05T20:26:29Z

`47f7dec`

Assign generic role to aside tag within the sectioning content elements
https://bugs.webkit.org/show_bug.cgi?id=235065
rdar://problem/87391915

Reviewed by Tyler Wilcock.

This change assigns a generic ARIA role to <aside> elements when they are nested
within <aside>, <article>, <section>, or <nav> elements, aligning with the spec
(https://w3c.github.io/html-aam/#el-aside).
This follows the discussion in w3c/html-aam#512

Additionally, it introduces a check to return LandmarkComplementary when an <aside>
tag has an explicit accessible name.

* LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-contextual-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-contextual.html:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):

Canonical link: https://commits.webkit.org/270509@main

131b7bc

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-11-05T20:26:41Z

EWS run on previous version of this PR (hash 3bde303)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-11-06T04:08:48Z

EWS run on previous version of this PR (hash 66b603a)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-11-06T19:57:04Z

EWS run on previous version of this PR (hash 84a3800)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch		⏳ 🛠 jsc-mips
	✅ 🛠 watch-sim		⏳ 🧪 jsc-mips-tests

twilco

Thanks for working on this! Left some comments.

LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-contextual.html

webkit-early-warning-system · 2023-11-08T08:17:03Z

EWS run on current version of this PR (hash ee661cc)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
⏳ 🧪 style	⏳ 🛠 ios	🛠 mac	⏳ 🛠 wpe	⏳ 🛠 wincairo
🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
🧪 webkitperl	⏳ 🧪 ios-wk2	🧪 api-mac	⏳ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	🧪 mac-wk1	⏳ 🧪 gtk-wk2
	⏳ 🧪 api-ios	🧪 mac-wk2	⏳ 🧪 api-gtk
	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
🧪 services	⏳ 🛠 tv-sim	🧪 mac-wk2-stress
	⏳ 🛠 watch		⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim		⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-11-08T08:17:04Z

EWS run on previous version of this PR (hash ee661cc)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

twilco

Almost there!

Source/WebCore/accessibility/AccessibilityNodeObject.cpp

webkit-early-warning-system · 2023-11-10T00:43:35Z

EWS run on current version of this PR (hash 131b7bc)

Details

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

twilco

Thank you @joone!

https://bugs.webkit.org/show_bug.cgi?id=235065 rdar://problem/87391915 Reviewed by Tyler Wilcock. This change assigns a generic ARIA role to <aside> elements when they are nested within <aside>, <article>, <section>, or <nav> elements, aligning with the spec (https://w3c.github.io/html-aam/#el-aside). This follows the discussion in w3c/html-aam#512 Additionally, it introduces a check to return LandmarkComplementary when an <aside> tag has an explicit accessible name. * LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-contextual-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-contextual.html: * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const): Canonical link: https://commits.webkit.org/270509@main

webkit-commit-queue · 2023-11-10T07:11:11Z

Committed 270509@main (47f7dec): https://commits.webkit.org/270509@main

Reviewed commits have been landed. Closing PR #20013 and removing active labels.

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 5, 2023

joone force-pushed the a11y/aside_complementary branch from 3bde303 to 66b603a Compare November 6, 2023 04:08

joone force-pushed the a11y/aside_complementary branch from 66b603a to 84a3800 Compare November 6, 2023 19:56

twilco reviewed Nov 7, 2023

View reviewed changes

LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-contextual.html Outdated Show resolved Hide resolved

LayoutTests/imported/w3c/web-platform-tests/html-aam/roles-contextual.html Outdated Show resolved Hide resolved

joone force-pushed the a11y/aside_complementary branch from 84a3800 to ee661cc Compare November 8, 2023 08:16

joone requested a review from twilco November 8, 2023 20:54

twilco reviewed Nov 9, 2023

View reviewed changes

Source/WebCore/accessibility/AccessibilityNodeObject.cpp Outdated Show resolved Hide resolved

Source/WebCore/accessibility/AccessibilityNodeObject.cpp Outdated Show resolved Hide resolved

Source/WebCore/accessibility/AccessibilityNodeObject.cpp Outdated Show resolved Hide resolved

twilco reviewed Nov 9, 2023

View reviewed changes

Source/WebCore/accessibility/AccessibilityNodeObject.cpp Outdated Show resolved Hide resolved

joone force-pushed the a11y/aside_complementary branch from ee661cc to 131b7bc Compare November 10, 2023 00:41

twilco approved these changes Nov 10, 2023

View reviewed changes

twilco added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Nov 10, 2023

webkit-commit-queue force-pushed the a11y/aside_complementary branch from 131b7bc to 47f7dec Compare November 10, 2023 07:11

webkit-commit-queue merged commit 47f7dec into WebKit:main Nov 10, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 10, 2023

This was referenced May 13, 2024

landmark-unique violation at /examples/kitchen-sink/generic.html pydata/pydata-sphinx-theme#1479

Closed

landmark-unique does not reflect latest HTML-role mappings dequelabs/axe-core#4460

Closed

Conversation

joone commented Nov 5, 2023 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

47f7dec

Uh oh!

webkit-early-warning-system commented Nov 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twilco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twilco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twilco left a comment

Choose a reason for hiding this comment

Uh oh!

webkit-commit-queue commented Nov 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

joone commented Nov 5, 2023 •

edited by webkit-early-warning-system

Loading

`47f7dec`

webkit-early-warning-system commented Nov 5, 2023 •

edited

Loading

webkit-early-warning-system commented Nov 6, 2023 •

edited

Loading

webkit-early-warning-system commented Nov 6, 2023 •

edited

Loading

webkit-early-warning-system commented Nov 8, 2023 •

edited

Loading

webkit-early-warning-system commented Nov 8, 2023 •

edited

Loading

webkit-early-warning-system commented Nov 10, 2023 •

edited

Loading