Skip to content

Change navigable target names to _blank if they have dangling markup#16885

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
sideshowbarker:navigableTargetNameBlankIfContainsDanglingMarkup
Aug 22, 2023
Merged

Change navigable target names to _blank if they have dangling markup#16885
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
sideshowbarker:navigableTargetNameBlankIfContainsDanglingMarkup

Conversation

@sideshowbarker
Copy link
Copy Markdown
Member

@sideshowbarker sideshowbarker commented Aug 21, 2023 •
edited by webkit-early-warning-system
Loading

6752480

Change navigable target names to _blank if they have dangling markup
https://bugs.webkit.org/show_bug.cgi?id=257349

Reviewed by Chris Dumez.

whatwg/html#9309

* LayoutTests/imported/w3c/resources/import-expectations.json:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/dangling-markup-window-name.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/dangling-markup-window-name.tentative.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/resources/window-name.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/w3c-import.log:
* LayoutTests/tests-options.json:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::makeTargetBlankIfHasDanglingMarkup const):
* Source/WebCore/dom/Element.h:
* Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::effectiveTarget const):
* Source/WebCore/html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::effectiveTarget const):

Canonical link: https://commits.webkit.org/267154@main

88ca711

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Aug 21, 2023 •
edited
Loading

EWS run on previous version of this PR (hash aa2a85c)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Aug 21, 2023
cdumez
cdumez approved these changes Aug 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits.

Comment thread Source/WebCore/dom/Element.h Outdated
Comment thread Source/WebCore/html/HTMLAnchorElement.cpp Outdated
Comment thread Source/WebCore/html/HTMLFormElement.cpp Outdated
Comment thread Source/WebCore/html/HTMLFormElement.cpp Outdated
Comment thread ...utTests/imported/w3c/web-platform-tests/html/browsers/windows/resources/window-name.sub.html Outdated
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Aug 21, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 45d2a2c)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🛠 gtk
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
❌ 🧪 api-ios ❌ 🧪 mac-wk2 ❌ 🧪 api-gtk
❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
❌ 🛠 tv-sim ❌ 🧪 mac-wk2-stress
❌ 🛠 watch
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 21, 2023
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Aug 21, 2023 •
edited
Loading

EWS run on previous version of this PR (hash a04ef02)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ❌ 🛠 gtk
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
❌ 🧪 api-ios ❌ 🧪 mac-wk2 ❌ 🧪 api-gtk
❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
❌ 🛠 tv-sim ❌ 🧪 mac-wk2-stress
❌ 🛠 watch
❌ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Aug 21, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 633f32c)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios   🛠 mac   🛠 wpe   🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ❌ 🛠 gtk
❌ 🧪 ios-wk2-wpt   🧪 mac-wk1 ❌ 🧪 gtk-wk2
❌ 🧪 api-ios   🧪 mac-wk2 ❌ 🧪 api-gtk
❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
❌ 🛠 tv-sim   🧪 mac-wk2-stress
❌ 🛠 watch
❌ 🛠 watch-sim

@sideshowbarker sideshowbarker force-pushed the navigableTargetNameBlankIfContainsDanglingMarkup branch from 633f32c to 2ba9cd0 Compare August 21, 2023 16:35
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Aug 21, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 2ba9cd0)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@sideshowbarker sideshowbarker force-pushed the navigableTargetNameBlankIfContainsDanglingMarkup branch from 2ba9cd0 to f9f25b1 Compare August 22, 2023 00:50
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Aug 22, 2023 •
edited
Loading

EWS run on previous version of this PR (hash f9f25b1)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch ⏳ 🛠 jsc-mips
✅ 🛠 watch-sim ⏳ 🧪 jsc-mips-tests

@sideshowbarker sideshowbarker force-pushed the navigableTargetNameBlankIfContainsDanglingMarkup branch from f9f25b1 to 88ca711 Compare August 22, 2023 10:57
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

webkit-early-warning-system commented Aug 22, 2023 •
edited
Loading

EWS run on current version of this PR (hash 88ca711)

Details

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 removed the merging-blocked Applied to prevent a change from being merged label Aug 22, 2023
@Ahmad-S792
Copy link
Copy Markdown
Contributor

Ahmad-S792 commented Aug 22, 2023

@sideshowbarker - you want me to add 'merge-queue' to this?

@sideshowbarker
Copy link
Copy Markdown
Member Author

sideshowbarker commented Aug 22, 2023

@sideshowbarker - you want me to add 'merge-queue' to this?

Yes please 👍

@Ahmad-S792 Ahmad-S792 added the merge-queue Applied to send a pull request to merge-queue label Aug 22, 2023
@sideshowbarker
Change navigable target names to _blank if they have dangling markup
6752480 
https://bugs.webkit.org/show_bug.cgi?id=257349

Reviewed by Chris Dumez.

whatwg/html#9309

* LayoutTests/imported/w3c/resources/import-expectations.json:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/dangling-markup-window-name.tentative-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/dangling-markup-window-name.tentative.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/resources/window-name.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/html/browsers/windows/w3c-import.log:
* LayoutTests/tests-options.json:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::makeTargetBlankIfHasDanglingMarkup const):
* Source/WebCore/dom/Element.h:
* Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::effectiveTarget const):
* Source/WebCore/html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::effectiveTarget const):

Canonical link: https://commits.webkit.org/267154@main
@webkit-commit-queue webkit-commit-queue force-pushed the navigableTargetNameBlankIfContainsDanglingMarkup branch from 88ca711 to 6752480 Compare August 22, 2023 22:57
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

webkit-commit-queue commented Aug 22, 2023

Committed 267154@main (6752480): https://commits.webkit.org/267154@main

Reviewed commits have been landed. Closing PR #16885 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6752480 into WebKit:main Aug 22, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Aug 22, 2023
@shhnjk shhnjk mentioned this pull request Aug 22, 2023
Merged
3 tasks
@sideshowbarker
Copy link
Copy Markdown
Member Author

sideshowbarker commented Aug 22, 2023

@Ahmad-S792 Thanks much

@sideshowbarker sideshowbarker deleted the navigableTargetNameBlankIfContainsDanglingMarkup branch August 22, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nt1m nt1m nt1m left review comments

@cdumez cdumez cdumez approved these changes

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

Assignees

@sideshowbarker sideshowbarker

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sideshowbarker @webkit-early-warning-system @Ahmad-S792 @webkit-commit-queue @cdumez @nt1m @webkit-ews-buildbot