Skip to content

Rename round to nearestint.#38

Merged
rossberg merged 1 commit intomasterfrom
nearestint
Sep 2, 2015
Merged

Rename round to nearestint.#38
rossberg merged 1 commit intomasterfrom
nearestint

Conversation

@sunfishcode
Copy link
Member

This is what the design repo calls it. And in particular, it's useful to
avoid calling it "round" because it's semantically different from both
JS's Math.round and C's round.

@jfbastien
Copy link
Member

Not for this PR, but it would be good to test that this is indeed the behavior of the ML prototype.

@sunfishcode
Copy link
Member Author

It's in the TestingTodo.md already :-) :

  • test that nearestint doesn't do JS-style Math.round or C-style round(3) rounding

@rossberg
Copy link
Member

rossberg commented Sep 2, 2015

LGTM, but why not simply name it "Nearest"? The Int suffix seems kind of redundant and inconsistent with the other float rounding operators.

It's useful to avoid calling it "round" because it's semantically different
from both JS's Math.round and C's round.
@sunfishcode
Copy link
Member Author

I'm ok with "nearest". I updated the PR accordingly.

rossberg added a commit that referenced this pull request Sep 2, 2015
@rossberg rossberg merged commit 02668bb into master Sep 2, 2015
@rossberg rossberg deleted the nearestint branch September 2, 2015 17:58
sunfishcode added a commit to WebAssembly/design that referenced this pull request Sep 2, 2015
littledan pushed a commit to littledan/spec that referenced this pull request Mar 4, 2018
The new names are:
- `i32.extend8_s`
- `i32.extend16_s`
- `i64.extend8_s`
- `i64.extend16_s`

`i64.extend32_s` has also been added for consistency.

See issue WebAssembly#34.
eqrion pushed a commit to eqrion/wasm-spec that referenced this pull request Sep 18, 2019
Increase the table count limit to 100,000
ErikMcClure pushed a commit to innative-sdk/spec that referenced this pull request Jun 15, 2020
In particular, remove an invalid assertion and take into account that
WebAssembly functions always return a list of results.
dhil pushed a commit to dhil/webassembly-spec that referenced this pull request Mar 2, 2023
dhil pushed a commit to dhil/webassembly-spec that referenced this pull request Oct 3, 2023
Add explicit RTT support for casts
dhil added a commit to dhil/webassembly-spec that referenced this pull request Jul 31, 2024
This patch fixes the continuation subtyping issue. Resolves wasmfx#35.
CharlieTap pushed a commit to CharlieTap/spec that referenced this pull request Sep 25, 2025
stevenfontanella pushed a commit to stevenfontanella/spec that referenced this pull request Nov 12, 2025
spec:
    WebAssembly@ce89050a
  simd:
    WebAssembly/simd@770ce643
  memory64:
    WebAssembly/memory64@521927c2

This change was automatically generated by `update-testsuite.sh`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants