Conversation
These should probably be commutable so humans don't have to remember which order to read/write things in, but there's pushback and this really doesn't matter so fix it here, bikeshed on github. This will require an associated fix in sexpr-wasm's GCC torture test failure list. Ref: WebAssembly/wabt#17 Ref: WebAssembly/spec#205
kripken
added a commit
that referenced
this pull request
Jan 6, 2016
s2wasm: load/store swap offset/align params
jfbastien
added a commit
to WebAssembly/wabt
that referenced
this pull request
Jan 6, 2016
Fixed by: WebAssembly/binaryen#66 Some of the failures were hiding other failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These should probably be commutable so humans don't have to remember which order to read/write things in, but there's pushback and this really doesn't matter so fix it here, bikeshed on github.
This will require an associated fix in sexpr-wasm's GCC torture test failure list.
Ref: WebAssembly/wabt#17
Ref: WebAssembly/spec#205