Remove binaryen.js debug build changes to WASM_BIGINT flag#5654
Merged
Remove binaryen.js debug build changes to WASM_BIGINT flag#5654
Conversation
dschuff
reviewed
Apr 12, 2023
CMakeLists.txt
Outdated
| add_link_flag("-sERROR_ON_WASM_CHANGES_AFTER_LINK") | ||
| add_link_flag("-sWASM_BIGINT") | ||
| else() | ||
| # Note: to debug with DWARF you will need something like |
Member
There was a problem hiding this comment.
How about putting option(ENABLE_BIGINT "Enable wasm Bigint" OFF) and putting this behind the option to make it easy to enable this?
Member
There was a problem hiding this comment.
+1, and also can you elaborate on the comment a little more? It's not DWARF support doesn't exist in Binaryen at all, but it doesn't fully preserve some info, so...
Member
Author
There was a problem hiding this comment.
Sounds good, option added + comments.
aheejin
approved these changes
Apr 13, 2023
dschuff
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5647