fix: use _malloc/_free to allocate memory in setMemory#5625
Closed
mnater wants to merge 5 commits intoWebAssembly:mainfrom
Closed
fix: use _malloc/_free to allocate memory in setMemory#5625mnater wants to merge 5 commits intoWebAssembly:mainfrom
mnater wants to merge 5 commits intoWebAssembly:mainfrom
Conversation
kripken
reviewed
Apr 4, 2023
kripken
reviewed
Apr 5, 2023
Member
kripken
left a comment
There was a problem hiding this comment.
malloc/free looks good!
Please remove the other changes, though - I don't think we need to make the stack size customizable now. (And it has a downside as it bakes 64K as the default, rather than deferring to emscripten to set the default.)
Contributor
Author
|
I don't know a clean way to remove the older commits. 🤷♂️ |
mnater
added a commit
to mnater/binaryen
that referenced
this pull request
Apr 7, 2023
cleaned PR. Original: WebAssembly#5625 fixes WebAssembly#5595
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see issue #5595