Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Conversation

@danielbachhuber
Copy link
Member

Work in-progress

See #718, conversation on #759

@danielbachhuber
Copy link
Member Author

@WP-API/amigos #reviewmerge

@danielbachhuber
Copy link
Member Author

@joehoyle @rachelbaker Can I get your review and thoughts? This needs to go in sooner rather than later so we can work from it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielbachhuber Should the string format be included? 'format' => 'uri'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can be more specific if we'd like, or we can do another pass later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachelbaker
Copy link
Member

@danielbachhuber @joehoyle @rmccue I am still not sold on the idea of fixed schemas, but willing to acquiesce to a majority opinion. I see the rigidness as a drawback, and am concerned we wouldn't be solving a real problem. Just my opinion.

Looking through this PR brought the following questions to mind:

  1. How do we handle expressing the additional fields returned in non-default contexts?
  2. Are there only three User object schema properties defined because that schema is incomplete?

@danielbachhuber
Copy link
Member Author

I am still not sold on the idea of fixed schemas, but willing to acquiesce to a majority opinion.

I was under the assumption that we had all agreed on fixed schemas?

Are there only three User object schema properties defined because that schema is incomplete?

Oh, I didn't finish. I can finish User and Comment schemas before merging if you'd like

@danielbachhuber
Copy link
Member Author

I'm going to finish up schemas for all Resources, and then this will be ready for a final reviewmerge

danielbachhuber added a commit that referenced this pull request Feb 18, 2015
JSON Schemas for our Controllers, second attempt
@danielbachhuber danielbachhuber merged commit 201c2e6 into develop Feb 18, 2015
@danielbachhuber danielbachhuber deleted the 759-json-2 branch April 17, 2015 16:04
@rmccue rmccue mentioned this pull request Apr 28, 2015
46 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants