-
Notifications
You must be signed in to change notification settings - Fork 651
JSON Schemas for our Controllers, second attempt #844
Conversation
|
@WP-API/amigos #reviewmerge |
|
@joehoyle @rachelbaker Can I get your review and thoughts? This needs to go in sooner rather than later so we can work from it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielbachhuber Should the string format be included? 'format' => 'uri'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can be more specific if we'd like, or we can do another pass later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@danielbachhuber @joehoyle @rmccue I am still not sold on the idea of Looking through this PR brought the following questions to mind:
|
I was under the assumption that we had all agreed on fixed schemas?
Oh, I didn't finish. I can finish User and Comment schemas before merging if you'd like |
|
I'm going to finish up schemas for all Resources, and then this will be ready for a final reviewmerge |
Conflicts: lib/class-wp-json-posts-controller.php
JSON Schemas for our Controllers, second attempt
Work in-progress
See #718, conversation on #759