Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Posts controller abstraction #820

Merged
rachelbaker merged 9 commits into from
Feb 2, 2015
Merged

Posts controller abstraction #820

rachelbaker merged 9 commits into from
Feb 2, 2015

Conversation

@danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Jan 30, 2015

This pull request pulls the non-controversial changes out of #759 so we can continue moving forward.

Specifically, I have:

  • Collapsed WP_JSON_Base_Posts_Controller into a WP_JSON_Posts_Controller that can be used with multiple post types.
  • Automatically registered endpoints for post types registered with the show_in_json argument. The WP_JSON_Posts_Controller is used by default for these post types, but they would be able to register their own controller class.
  • Made resource fields reflect post_type_supports() and other post type attributes (e.g. a post type has to support title for it to be present in the response). Extra data included in POST and PUT requests is silently discarded.

This pull request does not:

  • Change the name of any fields.
  • Introduce a JSON Schema for each resource.

Once this is merged, I'll put together pull requests for each of the two aforementioned points.

See #718

@danielbachhuber danielbachhuber mentioned this pull request Jan 30, 2015
Closed
@rachelbaker rachelbaker mentioned this pull request Jan 30, 2015
Closed
2 tasks
@danielbachhuber danielbachhuber added this to the 2.0 milestone Jan 30, 2015
@danielbachhuber
Copy link
Member Author

danielbachhuber commented Jan 30, 2015

@WP-API/amigos #reviewmerge

@danielbachhuber danielbachhuber mentioned this pull request Jan 30, 2015
Closed
@rachelbaker rachelbaker mentioned this pull request Jan 31, 2015
Closed
This was referenced Feb 2, 2015
Closed
Closed
@joehoyle
Copy link
Member

joehoyle commented Feb 2, 2015

@danielbachhuber if I had a very custom post type, what would be the best way to subclass WP_JSON_Posts_Controller and use that subclass in the routes? Would I need to roll all my own register_json_route calls? Doh, just seen json_controller_class I guess that's for exactly this purpose. I was actually going to suggest this!

json_base arg name, would json_route be a little more descriptive? Don't want to bike-shed so not too bothered though!

+1 for merging

@danielbachhuber
Copy link
Member Author

danielbachhuber commented Feb 2, 2015

Doh, just seen json_controller_class I guess that's for exactly this purpose. I was actually going to suggest this!

Yep. Probably should also make sure that the supplied class name is a subclass of WP_JSON_Controller.

json_base arg name, would json_route be a little more descriptive? Don't want to bike-shed so not too bothered though!

Open to suggestions, or we can file another issue and come back to it.

rachelbaker added a commit that referenced this pull request Feb 2, 2015
@rachelbaker
Merge pull request #820 from WP-API/718-post-abstraction
2394838 
Posts controller abstraction
@rachelbaker rachelbaker merged commit 2394838 into develop Feb 2, 2015
@rachelbaker rachelbaker deleted the 718-post-abstraction branch February 2, 2015 23:40
@danielbachhuber danielbachhuber mentioned this pull request Feb 2, 2015
Merged
rachelbaker added a commit that referenced this pull request Feb 7, 2015
@rachelbaker
Remove legacy function to modify post_types attributes replaced with #…
0c8187a 
…820.
@rachelbaker rachelbaker mentioned this pull request Feb 7, 2015
Merged
@danielbachhuber danielbachhuber mentioned this pull request Feb 25, 2015
Closed
@danielbachhuber danielbachhuber mentioned this pull request Jul 6, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Enhancement

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@danielbachhuber @joehoyle @rachelbaker