This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Register post types for API based on access_in_json argument
#769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`json_base` specifies the base slug used for the post type. Like core's existing behavior, it will use `name` as the default. `json_controller_class` probably needs a better name. It specifies which controller class to use, because more complex post types will break outside the standard `WP_JSON_Posts_Controller` class.
Member
Author
|
@WP-API/amigos What do you think of this registration pattern? |
Member
Author
|
We should also automatically register revision and other endpoints based whether the post type supports those endpoints. |
Member
There was a problem hiding this comment.
@danielbachhuber can the be hooked into wp_loaded instead?
Member
Author
There was a problem hiding this comment.
Could be, why?
I added them just to get things working, with the assumption they'd eventually be committed to create_initial_post_types()
Member
Author
|
Continued in #820 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_basespecifies the base slug used for the post type. Like core'sexisting behavior, it will use
nameas the default.json_controller_classprobably needs a better name. It specifies whichcontroller class to use, because more complex post types will break
outside the standard
WP_JSON_Posts_Controllerclass.See #759, #718