Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Initial pass at new style Posts Controller #684

Merged
danielbachhuber merged 112 commits into from
Dec 22, 2014
Merged

Initial pass at new style Posts Controller #684

danielbachhuber merged 112 commits into from
Dec 22, 2014

Conversation

@rachelbaker
Copy link
Member

@rachelbaker rachelbaker commented Dec 4, 2014

Initial Controller routes and methods:

  • get all posts
  • get a post
  • get revisions for a post
  • create a post
  • update a post
  • delete a post

Test coverage routes and methods:

  • get all posts
  • get single post
  • get revisions for a post
  • create a post
  • update a post
  • delete a post

@rachelbaker
Initial pass at get_items and get_item Post Controller routes.
c0cd377 
- Included new class-wp-json-posts-controller.php file in plugin.
- Added GET posts and posts/id routes to initial registered routes.
- Migrated logic from old WP_JSON_Posts class for get_items.
- Migrated logic from old WP_JSON_Posts class for get_item.
- Migrated logic from old WP_JSON_Posts class to prepare response.
@rachelbaker
Only provide post status in the edit context.
69f617d
@rachelbaker
Migrate read and edit permission checks from WP_JSON_Posts class.
f2a441d
@rachelbaker
Clean up comments in get_items.
babe2fc
@rachelbaker
Register route for creating a post.
c4c7606
@rachelbaker
Add logic for creating posts to posts controller.
a79abfe
@rachelbaker
Correct variable name in prepare_item_for_database()
d509260
@rachelbaker
Migrate WP_JSON_Posts logic for update_item method.
bba9509
@rachelbaker
:Merge branch 'develop' into two-posts-routes
e3fd2f5
@rachelbaker
Applying fix from a255340 into Posts Controller.
e25da16 
- Props @NateWr
@rachelbaker
Remove return type from WP_JSON_Controller::get_items.
0e54628
@rachelbaker
Move checking of post type into separate method.
b23cd8c
@rachelbaker
Correct return type to WP_JSON_Response object in Docblocks.
e137400
@rachelbaker
Fix permission check in WP_JSON_Posts_Controller::get_items.
665ec68
@rachelbaker
Change Docblocks return value to match json_ensure_response.
5db8451
@rachelbaker
Define $request parameter object in Docblocks.
a607ae4
@rachelbaker
Get post_type object when checking object capabilities.
be538ab
@rachelbaker
Check edit permission when passing the edit context.
a7a0eaf
@rachelbaker
Use check_edit_permission method to confirm user is allowed to update…
d5b8f18 
… post.
@rachelbaker
Minor array alignment formatting fix.
d997888
@rachelbaker
Set $post_type variable for valid permission checks across all of pre…
29e497e 
…pare_item_for_database.
@rachelbaker
Fix bug where query parameters weren't being passed to $prepared_args.
b5c47e1
@rachelbaker
Remove references to invalid $filter variable in WP_JSON_Post_Control…
cd427b1 
…ler::get_items.
@rachelbaker
Merge branch 'develop' into two-posts-routes
76472f7
@rachelbaker
Use method constants for route registrations.
b341e76
@rachelbaker
Get params from request and clean up prepare_item_for_database.
97d246f 
- Added sanitization for request parameters.
- Extracted logic for processing author and status params into separate methods.
- Use get_params() to actually check and process request parameters.
@rachelbaker
Beginning of test coverage for the posts controller.
5624a93
@rachelbaker
Get the query parameters from the request for get_items.
228e6ec
@rachelbaker
No need to unset the post_type query var anymore.
acef82b
@rachelbaker
Only pass post_type to get_items query if it is set in the request. I…
edcc06b 
…ncludes test.
danielbachhuber
danielbachhuber reviewed Dec 22, 2014
View reviewed changes
lib/class-wp-json-base-posts-controller.php Outdated
Copy link
Member

@danielbachhuber danielbachhuber Dec 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why return null instead of an empty string?

@rachelbaker
WP_JSON_Base_Posts_Controller should extend WP_JSON_Controller.
829fa73
@rachelbaker
Fix indentation in WP_JSON_Base_Posts_Controller::create_item method.
ab7b1c0
@rachelbaker
Move get_item_revisions method into the base post class.
54b02aa
@rachelbaker
Rename check_edit_permission method to check_update_permission
625410d
@rachelbaker
Rename test method to match controller method names.
ec52d15
@rachelbaker
Remove duplicate placeholder method that now exists in parent.
0d101d9
@rachelbaker
Return WP_Error if revisions are not supported by given post.
ab072b0
@rachelbaker
Return empty string instead of null for empty excerpts.
a4b9e84
@rachelbaker
Use post_type property to confirm type isn't being changed on update
916508e
@rachelbaker
Abstract out delete permission check.
1427b85
@rachelbaker
Add missing DocBlocks
d9ed265
@rachelbaker
Handle post formats on create and update.
ded5f04 
Related #735
@rachelbaker
Add unit tests for handling format parameter on create and update.
821156c
@rachelbaker
Add sticky post handling to update.
9a569b6
@rachelbaker
Add unit test for sticky post handling on update.
e1e83f9
@rachelbaker
Copy link
Member Author

rachelbaker commented Dec 22, 2014

Still needs:

  • Abstraction in the Base class where json_url() is used. Any suggestions here of how we can dynamically get the correct route path?
  • Discussion on what to do with prepare_item_response(). Should this method be included in the Base class with a bunch of post_type_supports() conditions? Or abstracted out per endpoint Controller?
  • Confirmation that we don't need the embed context at all. Previously we have used this for "embedding" post_parents into a response.
  • Discussion on @danielbachhuber's suggestion of using get_item() instead of get_post(). I don't understand how this DRY's up the code, or would be useful.
  • Review on the Base class. Anything else we want to add/remove here?

danielbachhuber added a commit that referenced this pull request Dec 22, 2014
@danielbachhuber
Merge pull request #684 from WP-API/two-posts-routes
fb1b60e 
Initial pass at new style Posts Controller
@danielbachhuber danielbachhuber merged commit fb1b60e into develop Dec 22, 2014
@danielbachhuber danielbachhuber mentioned this pull request Dec 22, 2014
Merged
@rmccue rmccue mentioned this pull request Dec 23, 2014
Closed
@rachelbaker rachelbaker mentioned this pull request Dec 23, 2014
Closed
@danielbachhuber danielbachhuber mentioned this pull request Feb 22, 2015
Closed
@rachelbaker rachelbaker mentioned this pull request Mar 30, 2015
Merged
@rachelbaker rachelbaker deleted the two-posts-routes branch October 30, 2015 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@rachelbaker rachelbaker

Labels

Enhancement Review

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rachelbaker @danielbachhuber @rmccue